commentfixer does not fix CL links #54
Assignees
Labels
bug
Something isn't working
Comments
|
Probably something I did. Looking into it. |
|
Change https://go.dev/cl/629797 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Nov 19, 2024
The format for parsing times differed from the one used by the GitHub API. The error was silently lost. Instead, a zero time was returned, meaning all issues and comments appeared to be before the commentfix.Fixer's cutoff and were not processed. This CL should fix the problem for subsequent issues, but we still have to go back and manually fix the ones that were missed somehow. Besides using the right format, and testing it against actual values from GH, also panic on error so gaby fails fast. It was only because Cherry was observant that this was noticed at all. For #54. Change-Id: Ib639dd68cae950ccba1af8e798ea6ae2c9ba5e19 Reviewed-on: https://go-review.googlesource.com/c/oscar/+/629797 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@cherrymui reported
Gaby didn't linkify "CL 626615"
golang/go#66984 (comment)
(posted on 2024-11-11)
The last commentfix.Fixer:gerritlinks entry in the action log was
"https://api.github.com/repos/golang/go/issues/comments/2460822465" on 2024-11-06 21:30:07.
The text was updated successfully, but these errors were encountered: