Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-code-cover not show in symbolic link path file #3628

Open
XR-stb opened this issue Dec 13, 2024 · 1 comment
Open

go-code-cover not show in symbolic link path file #3628

XR-stb opened this issue Dec 13, 2024 · 1 comment

Comments

@XR-stb
Copy link

XR-stb commented Dec 13, 2024

What version of Go, VS Code & VS Code Go extension are you using?

Version Information
  • Run go version to get version of Go from the VS Code integrated terminal.
    • go version go1.22.2 linux/amd64
  • Run gopls -v version to get version of Gopls from the VS Code integrated terminal.
    • golang.org/x/tools/gopls v0.16.2
  • Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders.
    • 1.95.3
  • Check your installed extensions to get the version of the VS Code Go extension
    • v0.42.1
  • Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > Go: Locate Configured Go Tools command.

Share the Go related settings you have added/edited

Run Preferences: Open Settings (JSON) command to open your settings.json file.
Share all the settings with the go. or ["go"] or gopls prefixes.

Describe the bug

Coverage is only rendered on real paths, not soft link paths.
It seems to be a problem that has been around for a long time. I would like to ask if it has not been dealt with or if there is any consideration.
I think it should also be necessary to support the rendering of symbolic link paths?
image

Steps to reproduce the behavior:

  1. just create a simple code with xx_test.go
  2. and create this folder symbolic link
  3. then open symbolic link folder in vscode
  4. toggle to show go-cover

Screenshots or recordings

It seems to be a problem that has been around for a long time. I would like to ask if it has not been dealt with or if there is any consideration.
#1803
image

I had see in here to say that's a actual path: https://github.com/golang/vscode-go/blob/master/extension/src/goCover.ts#L231
so why can't use symbolic link path to render
1111
image

@gopherbot gopherbot added this to the Untriaged milestone Dec 13, 2024
@findleyr
Copy link
Member

Hi, thank you for reporting this issue.

Symbolic links are notoriously hard to deal with, as it requires every tool in a chain to preserve them. With that said, I hope that we can avoid this bug.

@findleyr findleyr modified the milestones: Untriaged, vscode-go/backlog Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants