Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression in 1.37.0 on FreeBSD] filament/backend/src/vulkan/platform/PlatformVulkanAndroidLinuxWindows.cpp:72:6: error: Not a supported Vulkan platform #6861

Closed
yurivict opened this issue Jun 1, 2023 · 2 comments · Fixed by #6863
Assignees
Labels
bug Something isn't working vulkan Issues with the Vulkan backend

Comments

@yurivict
Copy link

yurivict commented Jun 1, 2023

Describe the bug

/usr/ports/graphics/filament/work/filament-1.37.0/filament/backend/src/vulkan/platform/PlatformVulkanAndroidLinuxWindows.cpp:72:6: error: Not a supported Vulkan platform
    #error Not a supported Vulkan platform
     ^
/usr/ports/graphics/filament/work/filament-1.37.0/filament/backend/src/vulkan/platform/PlatformVulkanAndroidLinuxWindows.cpp:109:22: error: unused variable 'instance' [-Werror,-Wunused-variable]
    VkInstance const instance = (VkInstance) vkinstance;
                     ^
2 errors generated.

Desktop (please complete the following information):

  • OS: [e.g. iOS] FreeBSD 13.2
  • GPU: [e.g. NVIDIA GTX 1080] n/a
  • Backend: Vulkan

Additional context
1.36.0 didn't have such failure.

@romainguy romainguy added bug Something isn't working vulkan Issues with the Vulkan backend labels Jun 1, 2023
@yurivict
Copy link
Author

yurivict commented Jun 1, 2023

Vulkan is supported on FreeBSD the same way as on Linux.

All ifdefs should be updated accordingly, for example:

-    #elif defined(__linux__) && defined(FILAMENT_SUPPORTS_X11)
+    #elif (defined(__linux__) || defined(__FreeBSD__)) && defined(FILAMENT_SUPPORTS_X11)

@poweifeng
Copy link
Contributor

I did submit a fix, but FreeBSD is not really a supported or validated platform. I think you'd still need a patch like #6057 even with the fix I submitted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vulkan Issues with the Vulkan backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants