Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular references from Article #85

Open
thesheps opened this issue Sep 2, 2020 · 3 comments
Open

Circular references from Article #85

thesheps opened this issue Sep 2, 2020 · 3 comments

Comments

@thesheps
Copy link

thesheps commented Sep 2, 2020

It looks as though the existing System.Text.Json serialisation library is having problems trying to serialise the Article object graph upon trying to create a new article:

System.Text.Json.JsonException: A possible object cycle was detected which is not supported.

I've been able to fix this on my local (Ubuntu) setup by using the Newtonsoft library instead. If there's an appetite to go after this fix I can create a PR with my changes later this evening?

@adamhathcock
Copy link
Collaborator

Please submit a PR. I actually thought I was using Newtonsoft but my memory is fading.

System.Text.Json isn't very usable until .NET 5.0 or later

@thesheps
Copy link
Author

thesheps commented Sep 2, 2020 via email

@adamhathcock
Copy link
Collaborator

Should be fixed. No longer using Newtonsoft at all.
#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants