Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor frontend: window.location.reload(); #116

Open
2 tasks
grumpyp opened this issue Sep 3, 2023 · 2 comments
Open
2 tasks

refactor frontend: window.location.reload(); #116

grumpyp opened this issue Sep 3, 2023 · 2 comments
Assignees
@auksesir
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grumpyp
Copy link
Owner

grumpyp commented Sep 3, 2023

It would be better if we would use a Notification from the mantine Notification context which is already implemented and get rid of window.location.reload(); so we can just update the components using useEffect f.e. and notify that the upload of a file or the config was saved.

  • Notify on success
  • No complete reload()
@grumpyp grumpyp added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 3, 2023
@auksesir
Copy link
Contributor

auksesir commented Sep 3, 2023

Can I work on it?

@grumpyp
Copy link
Owner Author

grumpyp commented Sep 3, 2023

hey @auksesir

yes that would be great!
Happy to assist, let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@auksesir auksesir

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grumpyp @auksesir