Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

[RFC] Merge train_with_engine and train_with_trainer #100

Open
FrankLeeeee opened this issue May 5, 2022 · 0 comments
Open

[RFC] Merge train_with_engine and train_with_trainer #100

FrankLeeeee opened this issue May 5, 2022 · 0 comments

Comments

@FrankLeeeee
Copy link
Contributor

FrankLeeeee commented May 5, 2022

Describe the feature

In most examples, there are two files, namely train with engine and trainer. The code is highly redundant in these two files and we should just merge them into one file.
We can add an additional flag to let the user to choose to run with either engine or trainer. As engine provides better portability from user code to colossalai-style code, we should keep engine as the default.

@FrankLeeeee FrankLeeeee changed the title Merge train_with_engine and train_with_trainer [RFC] Merge train_with_engine and train_with_trainer May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant