-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[π] EAS build failing because of missing ios_app_id in app.json #581
Comments
Is this something related? https://github.com/expo/fyi/blob/main/root-expo-object.md#migrating-the-config There were some changes in |
I'm having the same problem, do you have a solution for this? |
@toadfansboy nop... not yet... I'mw waiting for some response here. My builds are totally blocked by this π€·ββοΈ |
@toadfansboy have you found any workaround here? I still have my releases blocked because of this. I'm considering removing the Ads until it gets fixed. |
Infortunately I'm thinking of doing the same thing as @BrodaNoel... Do you know which previous version would resolve this problem? π€ |
@maximebaudoin the only option would be to roll back to Expo SDK 50. I am right now trying some workarounds for this. If I get some luck, I'll let your know |
I don't know if I'm the only one, but with Expo SDK 50, I have the same problem. In fact, I have this problem from a minimum 1 or 2 months ago. |
I just tried this, and it worked on iOS. Right now, I'm duplicating all the configuration (
|
@BrodaNoel how about android build? Your guide is not work in iOS(root and root > expo > extra) |
@jb9229 but have you applied the patches from the PR as well? |
Can I patch "ios_config.sh"? |
You can implement "patch-package" (look for the NPM package). You make the changes in node_modules and then run 'npx patch-package react-native-google-mobile-ads' Then you need to as patch-package as a dependency in your package.json, and configure it to auto-run it post install. Sorry I can't give more details. I'm away from the computer. |
I tried many times, but I failed...; @BrodaNoel |
@jb9229 are you also copying all the config inside The key should be something like: |
@jb9229 you are on Expo SDK 51, right? |
definitly right |
Look, it really seems like you have everything exactly like my configuration, so, double check if this isn't a cache problem |
You have this dependency installed, right?
|
Check in the logs if after the |
Hi,
When I see your messages, I tested earlier by going back to Expo@51.x.x and applying the patch as explained above. And the error is still there. I specify that I follow all the instructions to the letter and test by executing the Am I forgetting something glaring ? I don't know... |
@jb9229 it's hard to tell from your screenshot but it looks like your "react-native-google-mobile-ads" key is outside of the "extra" key. It looks like you have something like:
instead of:
Can confirm that this patch, at least via manually updating |
It seems to be inside extra π€ Why don't you try to build on EAS servers, instead of in your local? That's what I am doing |
Apologies, I only saw the |
Are you guys having both If so, this might be the problem. PR #517 broke this case and PR #521 is supposed to fix it, but seems to come with more issued. In my projects I'm using the following patch (and apply it with diff --git a/node_modules/react-native-google-mobile-ads/ios_config.sh b/node_modules/react-native-google-mobile-ads/ios_config.sh
index b57451a..1df22c1 100755
--- a/node_modules/react-native-google-mobile-ads/ios_config.sh
+++ b/node_modules/react-native-google-mobile-ads/ios_config.sh
@@ -93,7 +93,7 @@ while true; do
echo "info: ($_CURRENT_LOOKUPS of $_MAX_LOOKUPS) Searching in '$_CURRENT_SEARCH_DIR' for a ${_JSON_FILE_NAME}/${_JS_APP_CONFIG_FILE_NAME} file."
- _SEARCH_RESULT=$(find "$_CURRENT_SEARCH_DIR" -maxdepth 2 \( -name ${_JSON_FILE_NAME} -o -name ${_JS_APP_CONFIG_FILE_NAME} \) -print | /usr/bin/head -n 1)
+ _SEARCH_RESULT=$(find "$_CURRENT_SEARCH_DIR" -maxdepth 2 -name ${_JSON_FILE_NAME} -print | /usr/bin/head -n 1)
if [[ "$(basename ${_SEARCH_RESULT})" = "${_JS_APP_CONFIG_FILE_NAME}" ]]; then
_IS_CONFIG_JS=true |
I have an iOS and Android app, with
I've tried to include Last chance is |
π This issue has been resolved in version 14.0.0 π The release is available on: Your semantic-release bot π¦π |
Does anyone have a fix for this, even after upgrading to the latest versions, I still can't build it I have tried patch-package, I have verified the node_modules/react-native-google-mobile-ads/ios_config_sh code to make sure it's exactly like the fix shared by @mikehardy but still can't get the app to build. I have also added the "react-native-google-mobile-ads" key under extra with no success. Thanks. |
What happened?
I'm building using
eas build -p ios
, and I'm getting this error:Consider that this error is suddenly happening after I upgraded to Expo SDK 51.
Now, the weird thing is that I have, and I always had (it was working before) the
ios_app_id
in myapp.json
. Like this:Platforms
iOS, but have not tested behavior on Android
React Native Info
Are your using Typescript?
package.json
app.json
ios/Podfile
android/build.gradle
Not visible on Expo
android/app/build.gradle
Not visible on Expo
android/settings.gradle
Not visible on Expo
AndroidManifest.xml
The text was updated successfully, but these errors were encountered: