-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type declarations for all wasm files? #49
Comments
Thank you! I'll try dive in and fix these up when I can. PRs are also welcome 🙇 |
Thanks for your patience. Is this affecting your usage of the modules at all? Typing this becomes difficult as it needs to be typed for the consuming environment. There might need to be different types depending on how it's being consumed due to WebAssembly being a non-standard import. E.g. Cloudflare resolves the import directly to a WebAssembly Module but there might be other bundlers or tools where this is not the case. I'll leave this as is for now as I don't think there's an easy work-around. |
Nope, I'll add |
This is already the case in squoosh. The types where added manually (or generated somehow) Original commit: GoogleChromeLabs/squoosh@273b421 |
title, https://github.com/jamsinclair/jSquash/blob/main/examples/cloudflare-worker-esm-format/src/index.js
PNG wasm seems to be fine.
The text was updated successfully, but these errors were encountered: