Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mention box-sizing: border-box #8

Open
sumbach opened this issue Nov 6, 2016 · 1 comment
Open

Explicitly mention box-sizing: border-box #8

sumbach opened this issue Nov 6, 2016 · 1 comment

Comments

@sumbach
Copy link

sumbach commented Nov 6, 2016

One of the guidelines, regarding which properties a parent component can alter and which it cannot, implicitly assumes box-sizing: border-box:

properties related to positioning and dimensions (e.g. position, margin, display, width, float, z-index etc) are OK

In particular, width and margin may be unsafe to alter (or at least have unexpected effects) unless the element has box-sizing: border-box.

I wouldn't recommend anything other than box-sizing: border-box these days, but it's still something that can trip people up, especially if they're not using a global reset/normalize.

@jareware
Copy link
Owner

jareware commented Nov 6, 2016

That's a good point, I'll try and clarify that assumption in an upcoming "2nd edition", thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants