Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitchy walking animation next to buildings on displays with high refresh rates #391

Open
MilesBHuff opened this issue Apr 1, 2022 · 9 comments

Comments

@MilesBHuff
Copy link
Contributor

It doesn't show in screenshots; but walking just above the fence near Alex in the starting town results in a very strange walking animation.
image

@MilesBHuff
Copy link
Contributor Author

Upon further investigation, this happens when next to anything that would block movement if walked into.

@MilesBHuff MilesBHuff changed the title Glitchy walking animation in certain part of town Glitchy walking animation next to buildings and such Apr 1, 2022
@jjppof
Copy link
Owner

jjppof commented Apr 1, 2022

Is it the same as #369 ?

@jjppof
Copy link
Owner

jjppof commented Apr 1, 2022

If it's not the issue, here is what I'm trying:
bug2

@MilesBHuff
Copy link
Contributor Author

MilesBHuff commented Apr 1, 2022

Not the same issue afaict (though maybe it's related?), and I don't see the issue in your gif; but it would probably require a 60fps animation to see. Screenshots only show intermediate positions, all of which look fine.

@MilesBHuff
Copy link
Contributor Author

MilesBHuff commented Apr 1, 2022

Huh. I can't repro on my 60hz monitor. It happened last night, on a 300hz monitor. Maybe it only happens at high refresh rates?

@jjppof
Copy link
Owner

jjppof commented Apr 1, 2022

Oh yeah, that could be an issue. requestAnimationFrame follows monitor refresh rates. Sou you're probably running at 300 fps... Phaser 2 changed its fps engine at 2.17, so I need to better understand how to at least limit it to 60 fps... The only problem is that I don't have a high refresh rate monitor to see what's going on 😁

This is related to #338

@MilesBHuff
Copy link
Contributor Author

MilesBHuff commented Apr 1, 2022

Got it! Well, if you need someone to test it, lmk! :)

@MilesBHuff MilesBHuff changed the title Glitchy walking animation next to buildings and such Glitchy walking animation next to buildings on displays with high refresh rates Apr 1, 2022
@jjppof
Copy link
Owner

jjppof commented Apr 1, 2022

Sure, many thanks! I won't be able to release the engine without fixing this issue somehow...
Will mark as duplicate.

@jjppof
Copy link
Owner

jjppof commented Apr 1, 2022

Duplicate of #338

@jjppof jjppof marked this as a duplicate of #338 Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants