Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat freeze after selecting Garet's Djinn option #546

Open
JCalHij opened this issue Oct 8, 2023 · 4 comments
Open

Combat freeze after selecting Garet's Djinn option #546

JCalHij opened this issue Oct 8, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@JCalHij
Copy link

JCalHij commented Oct 8, 2023

While battling Briggs and its party, the whole game froze. Logs show this error:

Uncaught TypeError: Cannot read properties of undefined (reading 'name')
    at g.preview_djinn_change (MainChar.ts:608:36)
    at e.DjinnStatsWindow.set_stats (DjinnStatsWindow.ts:107:42)
    at e.DjinnStatsWindow.set_djinn (DjinnStatsWindow.ts:131:14)
    at e.BattleDjinnWindow.update_stats (BattleDjinnWindow.ts:251:27)
    at e.BattleDjinnWindow.mount_window (BattleDjinnWindow.ts:259:14)
    at e.BattleDjinnWindow.open (BattleDjinnWindow.ts:375:14)
    at e.MainBattleMenu.on_ability_choose (MainBattleMenu.ts:227:16)
    at e.MainBattleMenu.inner_button_press (MainBattleMenu.ts:185:22)
    at e.HorizontalMenu.on_press (HorizontalMenu.ts:75:51)
    at e.ControlManager.p (ControlManager.ts:247:29)

I chose a Djinn from Isaac, then tried to choose a Djinn action for Garet.

image

@jjppof jjppof self-assigned this Oct 8, 2023
@jjppof jjppof added the bug label Oct 8, 2023
@jjppof jjppof added this to the battle menus milestone Oct 8, 2023
@jjppof
Copy link
Owner

jjppof commented Oct 8, 2023

I'll be taking a look at it. Many thanks for finding it!

@jjppof
Copy link
Owner

jjppof commented Oct 9, 2023

I wasn't able to reproduce it.
That's a weird issue, how were you able to make Garet become a Squire?
The error msg you pointed seems to be class related.
What's the djinn configuration you used?
Did you make any changes in class_db.json?
If you can give a more specific step-by-step to reproduce the issue, it's going to help a lot.

Many thanks!

@JCalHij
Copy link
Author

JCalHij commented Oct 9, 2023

I have tried reproducing it as well in the demo, but I wasn't able either. As far as I know, I got the Mars Djinn that appears on town, grabbed a couple chests then fought Briggs.

What's the djinn configuration you used?

Only Djinn swap was between Isaac and Garet (Flint <-> Fever).
I cannot remember the exact things I did during combat, but I revived Garet on the previous turn with Quartz.

Did you make any changes in class_db.json?

Playing directly on the browser demo.

That's a weird issue, how were you able to make Garet become a Squire?

I think the engine might be holding some reference to Isaac or something, as it is not possible that Garet becomes a Squire.

@jjppof
Copy link
Owner

jjppof commented Oct 10, 2023

I think the engine might be holding some reference to Isaac or something, as it is not possible that Garet becomes a Squire.

That's a good point, will check something in this sense.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants