Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge new pre_install_check.js [replaces pre_install_check.sh] #232

Open
johannish opened this issue Nov 5, 2014 · 1 comment
Open

Merge new pre_install_check.js [replaces pre_install_check.sh] #232

johannish opened this issue Nov 5, 2014 · 1 comment

Comments

@johannish
Copy link
Collaborator

Because the pre_install_check.sh must be sourced, it receives all environment variables as set for the current shell. However, node-gyp itself will run in a sub-shell and may not see the same variables.

This caused an issue for me just now where I had set OCI_LIB_DIR=... in my .bashrc without the export command. Thus, pre_install_check.sh reported that everything was okay, even though node-gyp could not see those same environment variables.

@johannish
Copy link
Collaborator Author

Ha! So I just realized that this was fixed by the further work you did back in February, @vrvolle. I'll work on merging those changes in and testing the full workflow.

@johannish johannish changed the title pre_install_check.sh incorrectly reports environment variables Merge new pre_install_check.js [replaces pre_install_check.sh] Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant