Properly configure null ls with eslint_d and yarn pnp

[GabeDuarteM]

Hey 👋

I have a repo configured with yarn pnp, and I found very little info on how to configure it along with yarn pnp. I found some people using some command_resolver.from_yarn_pnp() (which I assume comes from local command_resolver = require("null-ls.helpers.command_resolver")?), but I have not found anything about that on the docs, and I'm also not sure if that would work with eslint_d, which is a daemon that should be installed globally anyway. Based on this issue on eslint_d, it seems like I could use something like:

local sdks = vim.fn.finddir('.yarn/sdks', ';')

[...]

    local args = {
      "--eslint-path", sdks .. "/eslint/lib/api.js",
      "-f", "json", "--stdin", "--stdin-filename", "$FILENAME"
    }
    -- setup null-ls to use eslint_d with yarn pnp
    null_ls.register(null_ls.builtins.diagnostics.eslint_d.with({
      args = args,
    }))

but if I do that, I get failed to decode json: Expected value but found invalid token at character 1 eslint_d [1, 1], so it seems to be erroring out

is there an easy way of achieving this? I'll probably need something similar for prettierd as well

[jose-elias-alvarez]

Yes, as you've noted the command resolver isn't appropriate for this case, since the goal of that is to find and use a local executable. Can you try enabling debug mode and see what eslint_d output looks like?

[GabeDuarteM]

Sure, the logs from that session:

[TRACE Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:97: starting null-ls client
[TRACE Sat 01 Apr 2023 01:52:07 AM UTC] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:102: received LSP request for method initialize
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:152: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///[file]"
  }
}
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:152: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///[file]"
  }
}
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:152: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///[file]"
  }
}
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:152: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///[file]"
  }
}
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:152: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///[file]"
  }
}
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:152: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///[file]"
  }
}
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...te/pack/packer/start/null-ls.nvim/lua/null-ls/client.lua:152: unable to notify client for method textDocument/didOpen (client not active): {
  textDocument = {
    uri = "file:///[file]"
  }
}
[TRACE Sat 01 Apr 2023 01:52:07 AM UTC] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:127: received LSP notification for method initialized
[TRACE Sat 01 Apr 2023 01:52:07 AM UTC] .../site/pack/packer/start/null-ls.nvim/lua/null-ls/rpc.lua:127: received LSP notification for method textDocument/didOpen
[TRACE Sat 01 Apr 2023 01:52:07 AM UTC] ...ack/packer/start/null-ls.nvim/lua/null-ls/generators.lua:21: running generators for method NULL_LS_DIAGNOSTICS_ON_OPEN
[DEBUG Sat 01 Apr 2023 01:52:07 AM UTC] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:320: spawning command "eslint_d" at /home/[folder] with args { "--eslint-path", ".yarn/sdks/eslint/lib/api.js", "-f", "json", "--stdin", "--stdin-filename", "/home/[file]" }
[TRACE Sat 01 Apr 2023 01:52:08 AM UTC] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:204: error output: nil
[TRACE Sat 01 Apr 2023 01:52:08 AM UTC] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:205: output: No ESLint found

[TRACE Sat 01 Apr 2023 01:52:08 AM UTC] ...ck/packer/start/null-ls.nvim/lua/null-ls/diagnostics.lua:181: received diagnostics from source 4
[TRACE Sat 01 Apr 2023 01:52:08 AM UTC] ...ck/packer/start/null-ls.nvim/lua/null-ls/diagnostics.lua:182: { {
    col = 0,
    end_col = 0,
    end_lnum = 1,
    lnum = 0,
    message = "failed to decode json: Expected value but found invalid token at character 1",
    severity = 1,
    source = "eslint_d",
    user_data = {
      fixable = false
    }
  } }

I censored some of the text with [file] and [folder]. Apparently, the output is "No ESLint found", which is weird, because .yarn/sdks/eslint/lib/api.js does exist at the projects root folder

[jose-elias-alvarez]

Can you run eslint_d from the command line with the same arguments?

[GabeDuarteM]

hmmm, interesting, when I also run it from the command line I get the same No ESLint found output 🤔 most likely its a bug on eslint_d then?

[jose-elias-alvarez]

I can’t say for sure, but if it doesn’t run from the command line then there’s nothing we can do on our end - you’ll have to solve that first.