Try to add djhtml as formatting source

[luisiacc]

I have tried to add djhtml as a formatting source locally first, but I haven't succeeded and now I'm kind of stuck so I need some help. This tool does not accept stdin, so I have to use to_temp_file.

I got this

local h = require("null-ls.helpers")
local methods = require("null-ls.methods")

local FORMATTING = methods.internal.FORMATTING

return h.make_builtin({
    method = FORMATTING,
    filetypes = { "djangohtml", "htmldjango" },
    generator_opts = {
        command = "djhtml",
        args = { "$FILENAME" },
        to_temp_file = true,
    },
    factory = h.formatter_factory,
})

When I ran formatting on a file with htmldjango filetype, it did nothing.

However if I change to_temp_file for to_stdin, it does format, but because it formats just the file in disk, does not format the unsaved changes, so that's not good.

I try some debugging and saw that it was spawning a command djhtml /tmp/null-lsasdasdsa.html, so I ran that command manually to check if it was something from djhtml's part, but the output was as expected.

If someone wants to try you can use this html file and set the filetype manually to htmldjango.

<div>
{{ ref }}
        <div class="asd">
            {% ref = ref+1 %}
        {{ ref + 1 }}
    </div>
</div>

Correct output should be

<div>
{{ ref }}
    <div class="asd">
        {% ref = ref+1 %}
        {{ ref + 1 }}
    </div>
</div>

[luisiacc]

Ok, I got it to work with:

generator_opts = {
    command = "djhtml",
    args = { "-i", "$FILENAME" },
    to_temp_file = true,
    from_temp_file = true,
}

But I think the above example should've also work, if someome can explain why it did not it would be helpful.

What happens here is that the -i makes the command to format the file in place, so using from_temp_file makes it work, but by doing djhtml $FILENAME, the output goes to stdout, which is where is caught be default, or am I missing something?

[syphar]

Since I also had to make it work somehow, perhaps the better approach is to make PR to djhtml to correctly accept stdin and output to stdout?

( perhaps I'll give it a shot later today)

[syphar]

@luisiacc so, I was checking the source of djhtml, and it looks like it does what it should: when given no arguments, it reads from stdin, and writes to stdout.

That means that your initial config ( with to_stdin) should totally work, the problem is that you give it the filename (which it doesn't need).

This is my source definition, it should work for you too:

local null_ls = require("null-ls")
local helpers = require("null-ls.helpers")

return {
	method = null_ls.methods.FORMATTING,
	filetypes = { "jinja.html", "htmldjango" },
	generator = helpers.formatter_factory({
		command = "djhtml",
		args = function(params)
			return {
				"--tabwidth",
				vim.api.nvim_buf_get_option(params.bufnr, "shiftwidth"),
			}
		end,
		to_stdin = true,
	}),
}

perhaps I should now really create a PR :)

[luisiacc]

You can check it out here #409

[syphar]

you were quicker :)

I'll add the --tabwidth part on top when that one is merged, also the other file types.