Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for ACME certificate without ca.crt #222

Open
im-Kitsch opened this issue Dec 16, 2024 · 2 comments
Open

support for ACME certificate without ca.crt #222

im-Kitsch opened this issue Dec 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@im-Kitsch
Copy link

Hi, firstly thanks for your excellent work.
Is your feature request related to a problem? Please describe.
for initTLS there it requires tls.key, tls.crt, ca.crt but for ca file, most reliable institues like let's encrypt just generates tls.key tls.crt. Shall we also support certificate without ca.crt? I think many cases ca.crt is not needed except self-signed custom certificate.

@im-Kitsch im-Kitsch added the enhancement New feature or request label Dec 16, 2024
@im-Kitsch im-Kitsch changed the title support for public ca.crt support for ACME certificate without ca.crt Dec 16, 2024
@jp-gouin
Copy link
Owner

Hi @im-Kitsch , thanks 😊
That is a good idea to make ca.crt optional.
Would you like to submit a PR ?

@im-Kitsch
Copy link
Author

Hi, @jp-gouin , I would try to do that.

But to be honest I am not so familiar with this helm chart. So just few quick questions:

best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants