Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

askalono does not detect multiple licenses in a single file #40

Open
eclipseo opened this issue Apr 1, 2019 · 1 comment
Open

askalono does not detect multiple licenses in a single file #40

eclipseo opened this issue Apr 1, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@eclipseo
Copy link
Contributor

eclipseo commented Apr 1, 2019

See this file containing multiple licenses:
https://github.com/mvantellingen/python-zeep/blob/master/LICENSE

It contains both MIT and BSD, but askalono is not able to detect either.
@jpeddicord
Copy link
Owner

Sorry for the really slow reply on this; I've been super busy lately. askalono should be able to detect this, but you have to tell it to look for more than one license. Currently the command-line is unable to do that, but the library should. I'll investigate options for getting that into the CLI.

@jpeddicord jpeddicord added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 14, 2020
markus456 added a commit to markus456/askalono that referenced this issue Sep 15, 2024
@markus456
Add --multiple option to the CLI
89938c4 
The --multiple option enables uses ScanMode::TopDown to detect multiple
licenses in the same file. The confidence score is still zero for the
whole file but having a list of licenses in the file is still useful. An
improvement would be to use the individual confidence scores in the
reported total score.

Added a test case that uses the license from python-zeep that issue jpeddicord#40
is about where the file has one MIT and two BSD-3-Clause licenses in it.
@markus456 markus456 mentioned this issue Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpeddicord @eclipseo