From 75164b03491910e8802cc9cf8217a8805b28d7ca Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 18 Nov 2024 13:43:12 -0500 Subject: [PATCH 1/5] Make the README less misleading by putting some reasonable defaults in (instead of empty strings `''`) --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 045e39a6..97fc1000 100644 --- a/README.md +++ b/README.md @@ -54,7 +54,7 @@ This action sets up a Julia environment for use in actions by downloading a spec # Note: you can use X64, X86, and ARM64 as synonyms for x64, x86, and aarch64, respectively. # # Defaults to the architecture of the runner executing the job. - arch: '' + arch: 'default' # Set the display setting for printing InteractiveUtils.versioninfo() after installing. # @@ -70,12 +70,12 @@ This action sets up a Julia environment for use in actions by downloading a spec # never: Never print versioninfo # # Default: false - show-versioninfo: '' + show-versioninfo: 'false' # Set the path to the project directory or file to use when resolving some versions (e.g. `min`). # # Defaults to using JULIA_PROJECT if defined, otherwise '.' - project: '' + project: '.' ``` ### Outputs From 8f261f194b30e069685e66e8fb3d8b66bad67791 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 18 Nov 2024 13:54:38 -0500 Subject: [PATCH 2/5] Change `version: ''` to `version: '1'` --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 97fc1000..741a0a36 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,7 @@ This action sets up a Julia environment for use in actions by downloading a spec # For example, `1.10` may be parsed as `1.1`. # # Default: '1' - version: '' + version: '1' # The architecture of the Julia binaries. # From e47e95ae5d44e971158837f2eaa82ce9fcc7d7c9 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 18 Nov 2024 14:04:49 -0500 Subject: [PATCH 3/5] Apply suggestions from code review --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 741a0a36..009c33a0 100644 --- a/README.md +++ b/README.md @@ -53,7 +53,7 @@ This action sets up a Julia environment for use in actions by downloading a spec # # Note: you can use X64, X86, and ARM64 as synonyms for x64, x86, and aarch64, respectively. # - # Defaults to the architecture of the runner executing the job. + # Specifying `'default'` uses the architecture of the runner executing the job. arch: 'default' # Set the display setting for printing InteractiveUtils.versioninfo() after installing. From 72b4af0c0642993c98c675a2985731146abbec29 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 18 Nov 2024 14:31:01 -0500 Subject: [PATCH 4/5] Apply suggestions from code review Co-authored-by: Jameson Nash --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 009c33a0..f4419189 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ This action sets up a Julia environment for use in actions by downloading a spec # Set the path to the project directory or file to use when resolving some versions (e.g. `min`). # # Defaults to using JULIA_PROJECT if defined, otherwise '.' - project: '.' + project: ${{ env.JULIA_PROJECT }} or '.' (if JULIA_PROJECT is unset) ``` ### Outputs From 7318cce3bd4d9a95708d399a98c20b6ce90129b4 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 18 Nov 2024 14:32:35 -0500 Subject: [PATCH 5/5] Probably don't need those backticks --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f4419189..1c5f3827 100644 --- a/README.md +++ b/README.md @@ -53,7 +53,7 @@ This action sets up a Julia environment for use in actions by downloading a spec # # Note: you can use X64, X86, and ARM64 as synonyms for x64, x86, and aarch64, respectively. # - # Specifying `'default'` uses the architecture of the runner executing the job. + # Specifying 'default' uses the architecture of the runner executing the job. arch: 'default' # Set the display setting for printing InteractiveUtils.versioninfo() after installing.