From 01d509123fa40ad67c2c2fe3b8c19a98498aefa2 Mon Sep 17 00:00:00 2001 From: kawanamiyuu Date: Tue, 14 Jul 2020 00:21:43 +0900 Subject: [PATCH 1/3] refactor: final class --- src/Application.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Application.php b/src/Application.php index b4f1d70..01d1b12 100644 --- a/src/Application.php +++ b/src/Application.php @@ -11,7 +11,7 @@ /** * @SuppressWarnings("PMD.LongVariable") */ -class Application implements ApplicationInterface +final class Application implements ApplicationInterface { private RequestHandlerInterface $requestHandler; From 48f4628c0086216907167be18f8bee7a834350c1 Mon Sep 17 00:00:00 2001 From: kawanamiyuu Date: Tue, 14 Jul 2020 00:22:20 +0900 Subject: [PATCH 2/3] refactor: remove redundant phpdoc --- src/Application.php | 5 ----- src/ApplicationInterface.php | 3 --- 2 files changed, 8 deletions(-) diff --git a/src/Application.php b/src/Application.php index 01d1b12..d085ee3 100644 --- a/src/Application.php +++ b/src/Application.php @@ -19,11 +19,6 @@ final class Application implements ApplicationInterface private ResponseEmitterInterface $responseEmitter; - /** - * @param RequestHandlerInterface $requestHandler - * @param ExceptionHandlerInterface $exceptionHandler - * @param ResponseEmitterInterface $responseEmitter - */ public function __construct( RequestHandlerInterface $requestHandler, ExceptionHandlerInterface $exceptionHandler, diff --git a/src/ApplicationInterface.php b/src/ApplicationInterface.php index d9d024f..cf6a1dd 100644 --- a/src/ApplicationInterface.php +++ b/src/ApplicationInterface.php @@ -8,8 +8,5 @@ interface ApplicationInterface { - /** - * @param ServerRequestInterface $request - */ public function __invoke(ServerRequestInterface $request): void; } From b4136be4ff0a9202f1d570377febf6e602b34f03 Mon Sep 17 00:00:00 2001 From: kawanamiyuu Date: Tue, 14 Jul 2020 00:23:18 +0900 Subject: [PATCH 3/3] refactor: remove unused `@SuppressWarnings` --- src/Application.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Application.php b/src/Application.php index d085ee3..66ebc24 100644 --- a/src/Application.php +++ b/src/Application.php @@ -8,9 +8,6 @@ use Psr\Http\Server\RequestHandlerInterface; use Throwable; -/** - * @SuppressWarnings("PMD.LongVariable") - */ final class Application implements ApplicationInterface { private RequestHandlerInterface $requestHandler;