Rewrite build fails on GitHub actions

[ThreeDeeJay]

I cloned the c++ rewrite branch to try setting up daily builds like PR #52 but I'm getting compilation errors.
Initially I though it was because the project was targeting Visual Studio 2017 which works on Appveyor, but the master branch also targets VS 2017 and builds fine with VS 2022. I also tried using the oldest runner available on Github actions (VS 2019), but it still failed, even with more compilation errors. So any idea why it's failing?

Also, would you recommend using it as a replacement for the master branch? or are there any major features missing?🤔
I'm planning to record and upload a full Prince of Persia: The Two Thrones playthough soon™️, so I figured maybe I could try the rewrite to see if I can spot any issues, so it'd come in handy to know what to look for 👀👌

[kcat]

The compilation errors seem to be from a missing <string> include in propset.cpp.

DSSCL_WRITEPRIMARY, Capture, and FullDuplex aren't working/implemented currently. Some of the DirectSoundPrivate interface is also not all there. Many things should work though, so it's definitely worth trying out.

[UserGit-2021]

The compilation errors seem to be from a missing <string> include in propset.cpp.

DSSCL_WRITEPRIMARY, Capture, and FullDuplex aren't working/implemented currently. Some of the DirectSoundPrivate interface is also not all there. Many things should work though, so it's definitely worth trying out.

Should we expect a DSOAL update in the near future? There has been no update for a long time, 10 months have passed.

[mirh]

Atm work is flying like there's no tomorrow on openal-soft
So... delighted as I may also be to see this getting progress, let's not disturb the brisk development focus

[ThreeDeeJay]

Looks like one of the recent commits fixed this because GitHub actions builds of the rewrite branch are magically succeeding now so I'll go ahead and close this issue 👀👌
https://github.com/ThreeDeeJay/dsoal/releases/tag/latest-c%2B%2B-rewrite
https://github.com/ThreeDeeJay/dsoal/releases/download/latest-c%2B%2B-rewrite/DSOAL.zip
https://github.com/ThreeDeeJay/dsoal/releases/download/latest-c%2B%2B-rewrite/DSOAL+HRTF.zip