Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating actions/cache@v3 to v4 to run on node20 #14

Open
devlsat opened this issue Aug 6, 2024 · 21 comments
Open

Updating actions/cache@v3 to v4 to run on node20 #14

devlsat opened this issue Aug 6, 2024 · 21 comments

Comments

@devlsat
Copy link

devlsat commented Aug 6, 2024

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

actions/cache@v3 runs on node16 which is deprecated, requesting to migrate to v4

@kishaningithub
Copy link
Owner

@devlsat This action is a shell action and fundamentally does not use node js. However, note that Amazon linux 2 has problems running node 20 because of its dependency with old GLIBC version.

If you are facing issues in running, kindly consider this option

ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

@devlsat
Copy link
Author

devlsat commented Aug 7, 2024

Okay thanks for the update
So, doing #15 this won't help?
Since
image

@kishaningithub
Copy link
Owner

You are right.. this might help..

Looking into why the CI did not get triggered for your PR.

@devlsat
Copy link
Author

devlsat commented Aug 13, 2024

Closing the issue

@devlsat devlsat closed this as completed Aug 13, 2024
@kishaningithub
Copy link
Owner

kishaningithub commented Aug 18, 2024

Reopening this issue to keep track of making this action node version agnostic

@kishaningithub
Copy link
Owner

@devlsat This Concern of referencing old node version is now fixed with the latest release. If you run trigger a new job you should see it disappear. As a big performance bonus, the python installation time should go from ~1 minute to ~25 seconds .

Give it a spin and let know your feedback :-)

@devlsat
Copy link
Author

devlsat commented Aug 28, 2024

Facing this issue with the latest version
image

Was working fine with v1.0.8

@kishaningithub
Copy link
Owner

@devlsat Interestingly v1.0.8 also has references to the $HOME variable.. Thinking about potential root causes... you have any thoughts?

echo "installation_directory=${HOME}/.setup-python-amazon-linux/.python-versions/${exact_python_version}" >> $GITHUB_OUTPUT

@kishaningithub
Copy link
Owner

@devlsat Have released a possible fix for this in the latest release (v1.0.12).. Can you try running it with either v1.0.12 tag or v1 tag?

@devlsat
Copy link
Author

devlsat commented Aug 29, 2024

Nope
Same error, but got a description this time
image

@kishaningithub
Copy link
Owner

@devlsat If you login to the self hosted runner and run echo "$HOME" does it fail or succeed?

@devlsat
Copy link
Author

devlsat commented Sep 2, 2024

Blank empty output

@kishaningithub
Copy link
Owner

@devlsat Is this action directly running in the EC2 runner machine or within a Docker container runner?

@devlsat
Copy link
Author

devlsat commented Sep 2, 2024

Docker container runner

@kishaningithub
Copy link
Owner

kishaningithub commented Sep 2, 2024

I launched an EC2 with amazon linux 2023 AMI and i see $HOME is present (screenshot below).

What is the output of whoami command? Also is the container being started in a login shell if not this problem might occur

image

@kishaningithub
Copy link
Owner

@devlsat I have released a possible fix for this in the latest v1.0.13 version viz to force a login shell for bash execution. Can you try upgrading to v1.0.13 or trigger a new run with v1 version?

@devlsat
Copy link
Author

devlsat commented Sep 3, 2024

It doesnt
image

@kishaningithub
Copy link
Owner

@devlsat Which is the version of this action that is working fine for you?

@devlsat
Copy link
Author

devlsat commented Sep 6, 2024

v1.0.8 works perfectly

@kishaningithub
Copy link
Owner

@devlsat Have released a new version v1.0.14 which i think should fix the above issue. Kindly check and let me know.

@kishaningithub
Copy link
Owner

@devlsat Is it correct to assume the new versions of this action are working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants