Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging into Spring Boot DATA JDBC #39

Open
rudolfschmidt opened this issue Apr 13, 2024 · 2 comments
Open

Merging into Spring Boot DATA JDBC #39

rudolfschmidt opened this issue Apr 13, 2024 · 2 comments

Comments

@rudolfschmidt
Copy link

Hey,
have not tested your implementation but I tried data jdbc out and noticed that there is a lack of support for sqlite.

Your implementation looks not bad so I wonder why not merging into spring boot data jdbc directly?

@komamitsu
Copy link
Owner

@rudolfschmidt Thanks for the suggestion!

Let me share my thoughts. Most of the implementation of this project is a basically integration to inject SQLite specific behavior to Spring Data JDBC. So, I guess those implementation would be removed once the Spring Data JDBC team decides to officially support SQLite. So, I'm not feeling so motivated to ask them to merge this project.

Thanks again for considering it, though.

@rudolfschmidt
Copy link
Author

rudolfschmidt commented Apr 14, 2024

I agree but why not contributing with a PR then?

Please take a look and share your thoughts: spring-projects/spring-data-relational#1770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants