Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple streams with same name #99

Open
crell-ine opened this issue Jul 10, 2023 · 1 comment
Open

Multiple streams with same name #99

crell-ine opened this issue Jul 10, 2023 · 1 comment

Comments

@crell-ine
Copy link

Hello all,

we are currently trying to record streams from two instances of a software (BrainVision RDA) running on two different PCs. Since the stream names and IDs are fixed by the software, the only way to differentiate the streams is their hostname. In the latest release (1.16.4) of the LabRecorder, it is not possible to record both streams at the same time since only one of them is resolved (probably due to same name/id). In the 1.12 version, it was still possible to record both streams at the same time when the hostname was different. Would it be possible to include the hostname again for resolving streams?

Thank you in advance!

@cboulay
Copy link
Contributor

cboulay commented Jul 10, 2023

In mainwindow.cpp MainWindow::refreshStreams there are several lines where it does comparisons to see if a stream is already known. e.g.: known |= s.name() == k.name && s.type() == k.type && s.source_id() == k.id;

Can you please try modifying these lines to add a hostname check? e.g., append && s.hostname() == k.host to the line above. From a quick glance, it looks like the lines that need to be modified are 303, 329, 361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants