From 019041eef422476bbe131c92885c93c73e0dbb84 Mon Sep 17 00:00:00 2001
From: Erick Friis <erick@langchain.dev>
Date: Thu, 19 Sep 2024 17:15:43 -0700
Subject: [PATCH] infra: unset env vars in same step (#210)

---
 .github/workflows/_release.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/_release.yml b/.github/workflows/_release.yml
index 693a7494..8b9381f8 100644
--- a/.github/workflows/_release.yml
+++ b/.github/workflows/_release.yml
@@ -174,14 +174,6 @@ jobs:
         run: make integration_tests
         working-directory: ${{ inputs.working-directory }}
 
-      - name: Remove environment variables
-        run: |
-          unset AWS_ACCESS_KEY_ID
-          unset AWS_SECRET_ACCESS_KEY
-          unset AWS_REGION
-          # Verify they are removed
-          if [ -z "$AWS_ACCESS_KEY_ID" ]; then echo "AWS_ACCESS_KEY_ID is unset"; else echo "AWS_ACCESS_KEY_ID is still set"; fi
-
       - name: Get minimum versions
         working-directory: ${{ inputs.working-directory }}
         id: min-version
@@ -197,6 +189,14 @@ jobs:
           MIN_VERSIONS: ${{ steps.min-version.outputs.min-versions }}
         run: |
           poetry run pip install $MIN_VERSIONS
+
+          # unset AWS credentials to ensure they are not used in snapshots
+          unset AWS_ACCESS_KEY_ID
+          unset AWS_SECRET_ACCESS_KEY
+          unset AWS_REGION
+          # Verify they are removed
+          if [ -z "$AWS_ACCESS_KEY_ID" ]; then echo "AWS_ACCESS_KEY_ID is unset"; else echo "AWS_ACCESS_KEY_ID is still set"; fi
+          
           make tests
         working-directory: ${{ inputs.working-directory }}