Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site-specific G. logout indication #11

Open
peter-lyons-kehl opened this issue May 17, 2021 · 1 comment
Open

Site-specific G. logout indication #11

peter-lyons-kehl opened this issue May 17, 2021 · 1 comment

Comments

@peter-lyons-kehl
Copy link

peter-lyons-kehl commented May 17, 2021

When using with Google Bookmarks, and visiting https://gregoryszorc.com/blog/2021/05/12/why-you-shouldn't-use-git-lfs - in either Firefox or Chrome, Yawas float says "Signed out". However, I'm definitely signed on to Google - I refreshed https://www.google.com/bookmarks several times, restarted the browser...

Yawas keeps saving highlights (to G. Bookmarks) for other websites, but fails for this one.

I looked at Browser Console (Ctrl+Shift+J), but there was no error/warning related to Yawas.

@ldenoue
Copy link
Owner

ldenoue commented May 17, 2021

Thanks @peter-kehl the URL contained a single quote ' character which made Yawas fail (more precisely, the encodeURIComponent used wasn't escaping the ' character, but Google was so Yawas didn't find the return URL to be the same and thought the user was signed out).

Fixed now with 06fb387

I submitted the new version to both Google and Firefox but of course you can install it directly from the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants