-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orphaned highlights #5
Comments
Thanks for the suggestion Peter. |
Please try the 7.2.4 version.
You can also load it from Github by cloning the repo and installing from
source.
…On Fri, Dec 13, 2019 at 9:16 PM Peter Kehl ***@***.***> wrote:
Thanks for this new feature, Laurent.
I confirm that the red caption shows up when there is a missing highlight
match. However, contrary to your screenshot above, I get
- the total "X/Z highlights" includes the number of missing highlights
- clicking at the red caption doesn't show missing ones.
[image: image]
<https://user-images.githubusercontent.com/4270240/70829011-72bab400-1da1-11ea-89f0-e762e4d98e0d.png>
That's with the current version 7.2.3 in Firefox. However, I'm running
Firefox 72 Beta. I'll confirm this once 72 becomes release (as Firefox
doesn't let me back to 71) in about a week.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AABEQOMNBWSA4VOLAEYYOADQYPUSNA5CNFSM4JZFA52KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3EKAQ#issuecomment-565593346>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEQOM3U4QSJQB3JGIXGI3QYPUSNANCNFSM4JZFA52A>
.
|
This was referenced Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Laurent.
Related to #4 and its first example: Let's say you have existing Yawas highlights for a page, but the page changes subsequently and the text doesn't match the highlight in Yawas (whether full text, or "compressed"). Then you don't have a way of knowing that some of the existing/previous highlights are not visible on the page anymore.
Could Yawas somehow at least indicate that fact? And, if feasible, could it even show a list of those orphaned highlights, please? (For example, the "XYZ/PQR highlights" button at the bottom right could have a sub-buton, which would show those orphaned highlights in a popup, or in a separate tab.)
The text was updated successfully, but these errors were encountered: