Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned highlights #5

Open
peter-lyons-kehl opened this issue Dec 10, 2019 · 4 comments
Open

Orphaned highlights #5

peter-lyons-kehl opened this issue Dec 10, 2019 · 4 comments

Comments

@peter-lyons-kehl
Copy link

Hi Laurent.

Related to #4 and its first example: Let's say you have existing Yawas highlights for a page, but the page changes subsequently and the text doesn't match the highlight in Yawas (whether full text, or "compressed"). Then you don't have a way of knowing that some of the existing/previous highlights are not visible on the page anymore.

Could Yawas somehow at least indicate that fact? And, if feasible, could it even show a list of those orphaned highlights, please? (For example, the "XYZ/PQR highlights" button at the bottom right could have a sub-buton, which would show those orphaned highlights in a popup, or in a separate tab.)

@ldenoue
Copy link
Owner

ldenoue commented Dec 12, 2019

Thanks for the suggestion Peter.
It now shows the number of highlights that could not be remapped.
Next I'll try to add a link that actually shows you which ones couldn't be found.

@ldenoue
Copy link
Owner

ldenoue commented Dec 12, 2019

Now it also shows you the missing highlights when you click on the red caption.
image

@peter-lyons-kehl
Copy link
Author

Thanks for this new feature, Laurent.

I confirm that the red caption shows up when there is a missing highlight match. However, contrary to your screenshot above, I get

  • the total "X/Z highlights" includes the number of missing highlights
  • clicking at the red caption doesn't show missing ones.
    image

That's with the current version 7.2.3 in Firefox. However, I'm running Firefox 72 Beta. I'll confirm this once 72 becomes release (as Firefox doesn't let me back to 71) in about a week.

@ldenoue
Copy link
Owner

ldenoue commented Dec 13, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants