Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SoftwareSerial library api change #14

Open
coelner opened this issue Jun 27, 2019 · 1 comment
Open

SoftwareSerial library api change #14

coelner opened this issue Jun 27, 2019 · 1 comment

Comments

@coelner
Copy link

coelner commented Jun 27, 2019

Hey,

with the current version 5.2.2 for the esp8266 platform we have an api change in the library:
plerup/espsoftwareserial@2bbedb7#diff-8d137b6230feb3539a63ba9284979346

  1. move the Rx, Tx Pin to the begin()
  2. maybe optimize the buffer size
@lewapek
Copy link
Owner

lewapek commented Jul 8, 2019 •
edited
Loading

Hi,
thanks for reporting that!
Currently, I don't have time to check if the library will be compatible with the newer esp8266 platform having initialization refactored.

The best option (I don't know if possible) would be to add esp8266 platform version somewhere to dependencies or at least make note in the docs (readme).

I need to check if Arduino SoftwareSerial init is also updated in the similar way as esp8266

When I will find some time I will update and test the library

@lewapek lewapek mentioned this issue Aug 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lewapek @coelner