Additional events for --onevent
argument
#638
Replies: 4 comments
-
Seems to be under investigation. See eg. ashthespy@545c9ea |
Beta Was this translation helpful? Give feedback.
-
ooh, awesome! I hope to see that merged at some point 👍 |
Beta Was this translation helpful? Give feedback.
-
Thanks for getting started on this, my plan is to add events from SpIRC as well. As you said, having too many is better, as we'll eventually send them out as JSON in librespotd |
Beta Was this translation helpful? Give feedback.
-
Gimme a few days, will clean this up and submit a PR for a proper review :-) I'm aiming to incorporate the events @sashahilton00 mentions at plietar/librespot#37 (comment) |
Beta Was this translation helpful? Give feedback.
-
The
onevent
API is very useful to generate additional UI ontop oflibrespot
, without having to re-implement most of the CLI, however it's missing many events which could be useful.Looking through the runtime logs, there's lots of output from
librespot_connect::spirc
. Potentially these events could be channelled into the existingPlayerEvent
flow. I feel it's better to have too many events, that the user can filter out, than too few, and I have to parse thestdout
of the process (something I was partially tempted to do).If someone could point me to the best location to put the call to
run_program
, I'd be happy to contribute the code myself!Beta Was this translation helpful? Give feedback.
All reactions