Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with fast-syntax-highlighting #72

Open
musjj opened this issue May 14, 2023 · 3 comments
Open

Issue with fast-syntax-highlighting #72

musjj opened this issue May 14, 2023 · 3 comments

Comments

@musjj
Copy link

musjj commented May 14, 2023

With fast-syntax-highlighting, the syntax highlighting for the argument will be gone after you complete it and it won't return until you press another key:

2023-05-15T00.26.03.mp4
@musjj
Copy link
Author

musjj commented May 16, 2023

Fixed by loading the plugin before fast-syntax-highlighting. Adding this to the readme would probably be helpful.

@musjj musjj closed this as completed May 16, 2023
@lincheney
Copy link
Owner

lincheney commented May 17, 2023

Yeah I can do that.
I've never used fast-syntax-highlighting, but tbh flicking through their code, the plugin ordering looks like its a requirement of fast-syntax-highlighting not fzf-tab-completion given how they are modifying other widgets, so I'm surprised it's not documented in their installation process. I would expect anything that creates zsh widgets to run into this same problem as a result.
https://github.com/zdharma-continuum/fast-syntax-highlighting/blob/13d7b4e63468307b6dcb2dadf6150818f242cbff/fast-syntax-highlighting.plugin.zsh#L227

@musjj
Copy link
Author

musjj commented May 17, 2024

Tbh, I'm still having problems with this. When pressing Esc to close the fzf prompt, the syntax highlighting disappears. Do you have any idea what's causing this? This isn't a problem with the default fzf integration (Ctrl+T, Ctrl+R, etc.).

@musjj musjj reopened this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants