-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image source label to dockerfiles #141
Conversation
To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification. For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
i will add this to more linuxserver containers that matches the version tag with the source repo version (needed to match container version with release information). That way we get changelog information of the main app in things like renovate. if there is a special way i should open that PRs pls let me know, makes it easy for linuxserver and me :) and if wanted i could do this on every linuxserver repo not just the ones i use, pls let me know. |
I am a bot, here are the test results for this PR:
|
We already set OCI tags at build time https://github.com/linuxserver/docker-jenkins-builder/blob/e2790bd7f1a92dfeb005dcea4a743f23fb8e618a/roles/generate-jenkins/templates/Jenkinsfile.j2#L410 |
yes but the one of the linuxserver repo not the real source repo of the project.
so in renovate for example i get the changelog of the linuxserver repo not of the main bazarr repo where the actual infos are i want befor updating the container |
Your PR deviates from this definition. |
would it than be possible to merge the upstream changelog with yours? |
Its already there. https://github.com/linuxserver/docker-bazarr/releases/tag/v1.4.5-ls271 |
but ther eis no v1.4.5 tag, so that dont work. and ls271 is a changing suffix so nothing i could specify as a check. i think the easiest thing would be to add a github release with just the semver? but my bad to not checked that the release notes are there, just not for the semver tag as it seems |
To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification.
For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md