Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image source label to dockerfiles #141

Closed
wants to merge 1 commit into from

Conversation

wuast94
Copy link

@wuast94 wuast94 commented Oct 8, 2024

To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification.

For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md

To get changelogs shown with Renovate a docker container has to add the source label described in the OCI Image Format Specification.

For reference: https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/docker/readme.md
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@wuast94
Copy link
Author

wuast94 commented Oct 8, 2024

i will add this to more linuxserver containers that matches the version tag with the source repo version (needed to match container version with release information).

That way we get changelog information of the main app in things like renovate.

if there is a special way i should open that PRs pls let me know, makes it easy for linuxserver and me :)

and if wanted i could do this on every linuxserver repo not just the ones i use, pls let me know.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/bazarr/v1.4.5-pkg-7b17daa3-dev-4d6a5a84a66e3cd4217e889a6c18f8f0372b113e-pr-141/index.html
https://ci-tests.linuxserver.io/lspipepr/bazarr/v1.4.5-pkg-7b17daa3-dev-4d6a5a84a66e3cd4217e889a6c18f8f0372b113e-pr-141/shellcheck-result.xml

Tag Passed
amd64-v1.4.5-pkg-7b17daa3-dev-4d6a5a84a66e3cd4217e889a6c18f8f0372b113e-pr-141
arm64v8-v1.4.5-pkg-7b17daa3-dev-4d6a5a84a66e3cd4217e889a6c18f8f0372b113e-pr-141

@wuast94
Copy link
Author

wuast94 commented Oct 8, 2024

yes but the one of the linuxserver repo not the real source repo of the project.

 "Labels": {
                "org.opencontainers.image.authors": "linuxserver.io",
                "org.opencontainers.image.created": "2024-10-01T21:34:12+00:00",
                "org.opencontainers.image.description": "[Bazarr](https://www.bazarr.media/) is a companion application to Sonarr and Radarr. It can manage and download subtitles based on your requirements. You define your preferences by TV show or movie and Bazarr takes care of everything for you.",
                "org.opencontainers.image.documentation": "https://docs.linuxserver.io/images/docker-bazarr",
                "org.opencontainers.image.licenses": "GPL-3.0-only",
                "org.opencontainers.image.ref.name": "6378de0afb2426f00809be542468d85045f05e33",
                "org.opencontainers.image.revision": "6378de0afb2426f00809be542468d85045f05e33",
                "org.opencontainers.image.source": "https://github.com/linuxserver/docker-bazarr",
                "org.opencontainers.image.title": "Bazarr",
                "org.opencontainers.image.url": "https://github.com/linuxserver/docker-bazarr/packages",
                "org.opencontainers.image.vendor": "linuxserver.io",
                "org.opencontainers.image.version": "v1.4.4-ls270"

so in renovate for example i get the changelog of the linuxserver repo not of the main bazarr repo where the actual infos are i want befor updating the container

@Roxedus
Copy link
Member

Roxedus commented Oct 8, 2024

org.opencontainers.image is a specification, and has a clear, defined meaning of each label.

  • org.opencontainers.image.source URL to get source code for building the image (string)

Your PR deviates from this definition.

@Roxedus Roxedus closed this Oct 8, 2024
@wuast94 wuast94 deleted the patch-1 branch October 8, 2024 08:11
@wuast94
Copy link
Author

wuast94 commented Oct 8, 2024

would it than be possible to merge the upstream changelog with yours?

@Roxedus
Copy link
Member

Roxedus commented Oct 8, 2024

@wuast94
Copy link
Author

wuast94 commented Oct 8, 2024

but ther eis no v1.4.5 tag, so that dont work. and ls271 is a changing suffix so nothing i could specify as a check.

i think the easiest thing would be to add a github release with just the semver?

but my bad to not checked that the release notes are there, just not for the semver tag as it seems

@aptalca
Copy link
Member

aptalca commented Oct 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants