Game grashes when paused for too long

[luksamuk]

When the game is paused, if it remains that way for too long, it crashes. The game simply freezes.

I managed to reproduce this bug and I think it might be related to something in screen_level.c's code and BGM callbacks. Perharps this could be reproduced with a looping BGM on a new test screen.

[luksamuk]

Some more information on this bug.

• I was currently able to reproduce it by playing Surely Wood Zone on Mednafen for about 16 minutes.
• It crashed when the samples counter was equal to 3250, which is the loop point for the song.
• I'm not sure if this can be reproduced on PCSX-Redux, since it might crash the entire emulator.
• It seems more like an infinite loop of some sort. Could be the case that the song is trying to loop within its own callback.
• Soft-resetting on Mednafen works.

I will now try to reproduce this again with other levels, but it really seems like I might have to delegate the music looping to the update routine instead of using the CD callback itself.

[luksamuk]

Just reproduced this bug on Playground Act 1, at 32:30. Same issue: Game hangs at 4000 samples, which is the looping point for the music.

So IT IS a problem with the CD callback, but simulation might be easier on places with quicker songs such as Surely Wood.

[luksamuk]

Another crash: Eggmanland Zone, samples at 2829 (loop point is 2830). Crashet at 2:27. Might be the easiest way to simulate this. Plus, since Eggmanland is supposed to take more time to beat, this is really, really bad.