Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker instance is not thread-safe #6

Open
AlekSi opened this issue Jan 24, 2016 · 1 comment
Open

Faker instance is not thread-safe #6

AlekSi opened this issue Jan 24, 2016 · 1 comment

Comments

@AlekSi
Copy link

AlekSi commented Jan 24, 2016

Faker instance can't be used by different goroutines in parallel tests (t.Parallel()), there is a data race.
I propose to make it thread-safe, since creating new instance in every test is a waste of resources.
Alternatively, explicitly document that it's not thread-safe.
@AlekSi AlekSi mentioned this issue Apr 1, 2016
Closed
@AlekSi
Copy link
Author

AlekSi commented Jun 11, 2016

https://github.com/enodata/faker is thread-safe.

@AlekSi AlekSi mentioned this issue Jun 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlekSi