Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoparameterization does not run again if a parameter has been set by a previous skill #2

Closed
matthias-mayr opened this issue Sep 8, 2024 · 2 comments

Comments

@matthias-mayr
Copy link
Owner

@p-rosit: This is an example directly related to the workshop.

Setup

To get there, it's time to work with the workshop repos: https://github.com/ros-wg-delib/roscon24-workshop

git clone --recurse-submodules https://github.com/ros-wg-delib/roscon24-workshop.git
docker compose build
docker compose run base

Inside the container start the world

ros2 run delib_ws_worlds run --ros-args -p problem_number:=1

Start SkiROS2 with this:

ros2 launch skiros2_pyrobosim_lib main.launch.py

Running the skill

These parameter settings on a newly started world should work:
image

Nice to see. But there's a catch:
To get it to work, I had to introduce this parameter:

self.addParam("SecondStartLocation", Element("skiros:OpenableLocation"), ParamTypes.Inferred)

and use it here:

self.skill("Navigate", "", remap={"StartLocation": "SecondStartLocation", "TargetLocation": "ObjectTargetLocation"}),

which is not really how it should work

@matthias-mayr
Copy link
Owner Author

I circumvented this by explicitly setting the StartLocation in problem 1: 670146e

However, that's still only a workaround

@matthias-mayr
Copy link
Owner Author

I moved this issue to the SkiROS2 main repo since it's not specific to this repo: RobotLabLTH/SkiROS2#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant