Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sequoia beta] ui issue: all keys are marked as "locked" #560

Open
martinpaljak opened this issue Aug 13, 2024 · 3 comments
Open

[sequoia beta] ui issue: all keys are marked as "locked" #560

martinpaljak opened this issue Aug 13, 2024 · 3 comments

Comments

@martinpaljak
Copy link

All keys in the key list have a padlock, even the ones that are functioning as "notify only"

@maxgoedjen
Copy link
Owner

Yeah, I can also reproduce this. Not clear to me yet if it's a Sequoia bug or just a change in some underlying behavior I'll have to update for.

@martinpaljak
Copy link
Author

For me, all keys created before sequoia update show with a padlock. Keys crated with sequoia (incl. RC) look right all the time after creation. All keys work as expected, at least seem to.

@maxgoedjen
Copy link
Owner

https://github.com/maxgoedjen/secretive/blob/main/Sources/Packages/Sources/SecureEnclaveSecretKit/SecureEnclaveStore.swift#L272

This is where it's happening. Basically there's not a proper way to inspect for the auth-required attribute, so I have been comparing them with a reference. Something in the construction of this object must've changed between versions though, giving us these false positives. If I can figure out a way to fix this soonish, I"ll do that, but I may just have to remove this feature :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants