Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add fees to transaction and trade entries #1237

Open
zachgoll opened this issue Oct 3, 2024 Discussed in #1235 · 4 comments
Open

Feature Request: Add fees to transaction and trade entries #1237

zachgoll opened this issue Oct 3, 2024 Discussed in #1235 · 4 comments

Comments

@zachgoll
Copy link
Collaborator

zachgoll commented Oct 3, 2024

Discussed in #1235

Originally posted by marc22polo October 3, 2024

Describe the feature

A lot of banks (at least in my country) charge you a fee for transferring money between your accounts and because Maybe transfers the whole amount it does not show the correct total amount in the end (usually not a big amount, like sub 0.5€ but in the long run it adds up :)).
Also maybe add an option to choose who the bearer of the fee is (the receiver or the sender).

Why is this feature important?

The current work around is to create another transaction alongside the transfer transaction for the transfer fee. This would save time for such occasions.

Additional context, screenshots, and relevant links

No response

@alvaro-rrdt
Copy link

Hello Zack I am going to try to tackle this issue I was wondering if the fee is supposed to be dynamic? I would imagine that in different countries, banks etc the fees vary in % or quantity

@zachgoll
Copy link
Collaborator Author

@alvaro-rrdt nope, this would just be a simple addition to the schema and the trade forms where users can hard-code in a fee alongside each transaction.

I think this is broad enough where we can put it on the Account::Entry model and have it apply to transactions (currency conversion fees), trades (stock purchase fees), and valuations (asset valuation fees from external service).

@bastervrugt
Copy link

I agree with Zak, but a fee is not always directly related to a transaction. For example, a broker might charge fees for being connected to a specific stock exchange (e.g., DEGIRO). Adding a transaction type 'Fee' could be a good solution, complementing the fee on buy/sell/etc. transactions?

@zachgoll
Copy link
Collaborator Author

@bastervrugt yep, we could add a "Fee" type transaction! Should be very similar to "Interest" that we already have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants