Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest upgrade to Phoenix 1.4 #4

Open
9to1url opened this issue Feb 8, 2020 · 6 comments
Open

Suggest upgrade to Phoenix 1.4 #4

9to1url opened this issue Feb 8, 2020 · 6 comments

Comments

@9to1url
Copy link
Contributor

9to1url commented Feb 8, 2020

I suggest you upgrade Phoenix version to 1.4, as many libs need 1.4 now, otherwise can't use those functionalities. thanks.

@meddle0x53
Copy link
Owner

If you can support that, I'll be very happy!

@9to1url
Copy link
Contributor Author

9to1url commented Feb 14, 2020

I can try to upgrade to phx 1.4, but the edeliver part I am not sure, didn't use it before.

@9to1url
Copy link
Contributor Author

9to1url commented Feb 14, 2020

When I trying to upgrade to 1.4, I found your project structure more like 1.2 than 1.3. Even in mix.exs is 1.3 , Any idea?

@9to1url
Copy link
Contributor Author

9to1url commented Feb 14, 2020

Please review the PR, I followed the steps here to upgrade your 1.3 to phx 1.4:
https://gist.github.com/chrismccord/bb1f8b136f5a9e4abc0bfc07b832257e

I didn't touch the folder structure and didn't replace brunch with webpack. Do you need me to change this as well?

@9to1url
Copy link
Contributor Author

9to1url commented Feb 18, 2020

Hi Meddle,
I tested on my local machine, it is running fine after upgrade.

@9to1url
Copy link
Contributor Author

9to1url commented Mar 13, 2020

Hi Meddle,

I upgraded the folder structure to phx 1.3/1.4 by move all assets to /assets folder. also upgrade the brunch version.
Tested on my machine, working fine.
Please review and accept the PR.

I also tried to change brunch to webpack, but not successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants