JS, extern scripts #165
daniel-lewis-ab
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, I'm working on a project that involves examining a bunch of the ComfyUI nodes' JS.
In comfyui_shared.js:417 and note_plus.js you use a loadScript() to load ace.min.js into the script. NotePlus node wasn't visible in utils. I've disabled the remote script import for our purposes but just wanted to point out the state it was found in. This may be an out of date version issue that's already been fixed in your main? Regardless, the external path thing is something that would probably be best localized for security reasons for most uses.
web/extern/shodown.js being deleted seems to not cause any errors at a cursory glance, and I'm not sure why it's there? Solving this riddle is flagged as one of my remaining issues before we can include your node in a large project.
Beta Was this translation helpful? Give feedback.
All reactions