React 0.74 - Update defaultProps to JavaScript default parameters. #661

nd-gorm · 2024-05-15T07:19:05Z

Simba-Mupfunya · 2024-05-15T11:48:49Z

same issue as @nd-gorm

QuentinOber · 2024-05-15T19:16:58Z

same issue as @nd-gorm .-)

bruce-mec · 2024-05-16T13:32:18Z

Same, after upgrading to react native 0.74

ivanoikon · 2024-05-17T06:56:22Z

Same issue here. But the question is: is this project still alive?

yeezussniper · 2024-05-19T07:24:30Z

I see attempts to fix this (f0c7e34). But they failed the test.
There are suspicions that the project is really abandoned :(

djMax · 2024-05-19T21:23:52Z

I reached out with an offer to sponsor and have not heard back, so I have similar concerns. Perhaps time for a fork? Or perhaps @meliorence can add a maintainer.

ba361006 · 2024-05-21T08:33:35Z

same here, will show the warning as below

ERROR  Warning: TNodeChildrenRenderer: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
ERROR  Warning: MemoizedTNodeRenderer: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.
ERROR  Warning: TRenderEngineProvider: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

Version:

react-native-render-html: 6.3.4
react native: 0.74.1
react: 18.2.0

yeezussniper · 2024-05-21T17:47:06Z

@djMax and @ba361006
Eventually, I took this package and made it for myself inside my project

https://www.npmjs.com/package/htmlparser2-without-node-native

djMax · 2024-05-21T18:43:03Z

But this doesn't do any of the translation to React components, no? That's the main magic bit of this module, IMHO.

yeezussniper · 2024-05-21T18:47:01Z

No, I just needed to display the users html in the View

chriszs · 2024-05-28T02:59:33Z

The CI step that failed when merging a fix in #658 was a linting step. Lint errors were fixed in #660, in which regarding the potential for a release the maintainer said, "I cannot promise anything, but will consider releasing when I find some time off." So, a fix may be released, but not on any definite timeline.

linusrush · 2024-06-04T12:37:33Z

Also looking forward to the fix release

bytemtek · 2024-06-13T11:50:47Z

same issue as @nd-gorm

IvanMijic0 · 2024-06-13T17:00:38Z

Same issue as @nd-gorm

Cube321 · 2024-06-13T19:49:11Z

same issue as @nd-gorm

bytemtek · 2024-06-14T12:24:22Z

Is there any solution ?

ivanoikon · 2024-06-14T12:29:29Z

I solved switching to this library while waiting for a fix react-native-html-text-view.

bytemtek · 2024-06-14T14:38:36Z

I solved switching to this library while waiting for a fix react-native-html-text-view.

Thank you so much.

QuentinOber · 2024-06-14T16:30:45Z

I switched to react-native-htmlview and it's working fine so far; smooth transation.

tmeduho · 2024-06-17T18:57:02Z

@jsamr any update?

AronBe · 2024-06-18T11:15:24Z

@skb1129 was the work done but not yet released?

f0c7e34

tmeduho · 2024-06-24T14:35:28Z

@AronBe correct, see #660

ycldz · 2024-07-04T13:46:52Z

same issue

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @builder.io/sdk-react-native@1.0.34 ### Patch Changes - c787998: Fix: add `regeneratorRuntime` polyfill - c787998: Fix: replace `react-native-render-html` with `@builder.io/react-native-render-html` to remove `defaultProps` errors. See <meliorence/react-native-render-html#661> - c787998: Fix: disable async storage during static rendering (node.js) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

edritech93 · 2024-07-10T04:45:39Z

same issue for me, try switch to react-native-htmlview

vinz-mehra · 2024-07-11T21:47:30Z

@tmeduho So, do we have to wait now? or can we use this GitHub branch as a package on my project? Is there any workaround?

TheRealMikeD · 2024-07-11T23:35:05Z

Unfortunately, react-native-htmlview is missing a lot of features that this library has, which makes it a less than ideal replacement. At least, in my experience.

Hoping for a release soon!

david-cahill · 2024-09-04T10:48:46Z

Unfortunately the gitpkg approach results in a bunch of type declaration errors on my side. @jsamr Is there any chance you can publish 6.4.0 to npm to avoid these work-arounds?

bruce-mec · 2024-09-04T11:20:14Z

@david-cahill, I was able to use the patch suggested by @awlodarczyk above. This is how I got it to work.

Add the following as devDependencies

"patch-package": "^8.0.0" 
"postinstall-postinstall": "^2.1.0"

Create a "patches" folder in the root of your project
Copy the react-native-render-html+6.3.4.patch file into that folder.

Add postinstall to your scripts section in package.json

"scripts": {
    "postinstall": "patch-package"
    ......
}

You should now be able to run npm or yarn and get the following result.
** if you get an error about "patch....could not be parsed". It's likely a CRLF issue in the patch file sometimes caused by the windows file system if you're using windows. See here

% yarn
yarn install v1.22.22
[1/4] 🔍 Resolving packages...
success Already up-to-date.
$ patch-package
patch-package 8.0.0
Applying patches...
react-native-render-html@6.3.4 ✔
✨ Done in 0.52s.

DanielKuhn · 2024-09-04T14:34:00Z

Anyways, now that the fix is applied I get a new defaultProps-related warning from the table-plugin. I'll try to fix that next.

table-plugin fixed and PR opened: native-html/plugins#49

DanielKuhn · 2024-09-04T14:37:35Z

Unfortunately the gitpkg approach results in a bunch of type declaration errors on my side. @jsamr Is there any chance you can publish 6.4.0 to npm to avoid these work-arounds?

The defaultProps-fix-commit has been added after 6.4.0, so please make that 6.4.1.

@david-cahill for which packages do you get type declaration errors? Have you tried resolving the dependencies to updated versions? In my case (after fixing the table-plugin) I had to add this in the package.json in my project:

"resolutions": {
    "@native-html/table-plugin": "https://gitpkg.now.sh/codevise/native-html-plugins/packages/table-plugin?88f1d56a4ace850d9cab7de585515d092b735121",
    "@native-html/plugins-core": "https://gitpkg.now.sh/codevise/native-html-plugins/packages/plugins-core?26870f796ad4a3ef5d728c460382dfc981e5b2c5"
}

shawhu · 2024-09-05T04:38:24Z

the patch works...but seriously, we need a fork and a new package

david-cahill · 2024-09-05T14:52:26Z

Unfortunately the gitpkg approach results in a bunch of type declaration errors on my side. @jsamr Is there any chance you can publish 6.4.0 to npm to avoid these work-arounds?

The defaultProps-fix-commit has been added after 6.4.0, so please make that 6.4.1.

@david-cahill for which packages do you get type declaration errors? Have you tried resolving the dependencies to updated versions? In my case (after fixing the table-plugin) I had to add this in the package.json in my project:
"resolutions": {
    "@native-html/table-plugin": "https://gitpkg.now.sh/codevise/native-html-plugins/packages/table-plugin?88f1d56a4ace850d9cab7de585515d092b735121",
    "@native-html/plugins-core": "https://gitpkg.now.sh/codevise/native-html-plugins/packages/plugins-core?26870f796ad4a3ef5d728c460382dfc981e5b2c5"
}

@DanielKuhn I receive type errors for the react-native-render-html lib. It looks like the react-native-render-html/lib folder is missing in node_modules (it's not built) so imports are not working correctly. I've also tried the resolutions but without success.

iskifogl · 2024-09-06T05:13:47Z

patch is working for me as well but why nobody fork the project and create new packet or creater merge to this packet

dezudas · 2024-09-09T15:55:59Z

patch is working for me as well but why nobody fork the project and create new packet or creater merge to this packet

coz looks like everyone is hoping to update official release

Mako-L · 2024-09-13T12:58:16Z

Will be seeing any push to main npm package soon? I would love to see this warning gone from the cli. Thank you in advance you guys do an awesome job.

marcpope · 2024-09-16T23:37:17Z

the original author is looking for someone to take this over:
Looking for maintainers #669
#669

DorianMazur · 2024-09-23T07:41:14Z

Don't worry folks, we will fix it soon

- added patch shared on github to update package to prevent `defaultProps` warn in `react-native-render-html` package - meliorence/react-native-render-html#661 (comment) SVA-1429

haerim95 · 2024-10-04T07:35:09Z

if someone needs, here is patch-package fixing issue

react-native-render-html+6.3.4.patch

thanks, bro.
This resolved the warning error.

DorianMazur · 2024-10-10T09:38:58Z

The issue isn't with merging, but with deployment. The fix for that is already merged. We've lost contact with the owners of this package, and together with @jsamr, we're planning to move it to a different repository.

kirasiris · 2024-11-03T03:15:09Z

@ivanoikon @Cube321 Step 1: npm install --save-dev patch-package postinstall-postinstall Step 2: copy the 'react-native-render-html+6.3.4.patch' file to the patches folder that should exist in the route folder (ios, android, src, node_modules, patches) Step 3: add "scripts": { "postinstall": "patch-package" } if it is not there in package.json Step 4: npm install

post install should mean that when you build the patch is reapplied , hope this helps

@ivanoikon , thanks for the instructions. This was my first time implementing a "patch" and your instructions made it simple!

jsamr · 2024-11-03T15:58:49Z

I opened a ticket to track progress over here: #674

Note 1: pesting and requesting for this to happen quickly will not influence the process, I'm already doing the best I can, for free.

Note 2: you can suppress the warning with LogBox:

import { LogBox } from "react-native"

LogBox.ignoreLogs([
  /Support for defaultProps will be removed/,
]);

See the debugging basics official guide.

Note 3: this is a deprecation warning, the library still works.

StonedTD · 2024-11-06T10:37:34Z

And this would suppress errors (since they are no more warnings) from appearing in console as well:

if (__DEV__) {
  const ignoreErrors = ["Support for defaultProps will be removed"];

  const error = console.error;
  console.error = (...arg) => {
    for (const error of ignoreErrors) if (arg[0].includes(error)) return;
    error(...arg);
  };

  LogBox.ignoreLogs(ignoreErrors);
}

carlos-dubon · 2024-11-14T17:11:48Z

https://www.npmjs.com/package/@builder.io/react-native-render-html this fork seems to have already fixed this.

nd-gorm added the bug Crush'em all. label May 15, 2024

stevekuznetsov mentioned this issue Jun 13, 2024

ERROR Warning: bound renderChildren: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. NWACus/avy#755

Closed

samijaber mentioned this issue Jul 5, 2024

📦 Publish SDKs BuilderIO/builder#3381

Merged

mkzie2 mentioned this issue Sep 12, 2024

[HOLD for payment 2024-12-30] [HOLD] [Dev] Console Warning: TRenderEngineProvider: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. Expensify/App#49035

Open

6 tasks

jsamr assigned DorianMazur Sep 23, 2024

ardasnturk mentioned this issue Sep 27, 2024

fix: react-native-render-html default props error smart-village-solutions/smart-village-app-app#1191

Merged

This comment was marked as off-topic.

Sign in to view

kubabutkiewicz mentioned this issue Oct 29, 2024

[HOLD for payment 2024-11-29] Console error cleanup. Expensify/App#51099

Closed

This comment was marked as off-topic.

Sign in to view

meliorence locked as too heated and limited conversation to collaborators Nov 18, 2024

React 0.74 - Update defaultProps to JavaScript default parameters. #661

React 0.74 - Update defaultProps to JavaScript default parameters. #661

Comments

nd-gorm commented May 15, 2024 • edited Loading

Decision Table

Good Faith Declaration

Description

React Native Information

RNRH Version

Tested Platforms

Reproduction Platforms

Minimal, Reproducible Example

Additional Notes

Simba-Mupfunya commented May 15, 2024

QuentinOber commented May 15, 2024

bruce-mec commented May 16, 2024

ivanoikon commented May 17, 2024

yeezussniper commented May 19, 2024

djMax commented May 19, 2024

ba361006 commented May 21, 2024 • edited Loading

yeezussniper commented May 21, 2024

djMax commented May 21, 2024

yeezussniper commented May 21, 2024

chriszs commented May 28, 2024 • edited Loading

linusrush commented Jun 4, 2024

bytemtek commented Jun 13, 2024

IvanMijic0 commented Jun 13, 2024

Cube321 commented Jun 13, 2024

bytemtek commented Jun 14, 2024

ivanoikon commented Jun 14, 2024

bytemtek commented Jun 14, 2024

QuentinOber commented Jun 14, 2024

tmeduho commented Jun 17, 2024

AronBe commented Jun 18, 2024

tmeduho commented Jun 24, 2024

ycldz commented Jul 4, 2024

edritech93 commented Jul 10, 2024

vinz-mehra commented Jul 11, 2024

TheRealMikeD commented Jul 11, 2024

david-cahill commented Sep 4, 2024

bruce-mec commented Sep 4, 2024 • edited Loading

DanielKuhn commented Sep 4, 2024

DanielKuhn commented Sep 4, 2024 • edited Loading

shawhu commented Sep 5, 2024

david-cahill commented Sep 5, 2024

iskifogl commented Sep 6, 2024

dezudas commented Sep 9, 2024

Mako-L commented Sep 13, 2024

marcpope commented Sep 16, 2024 • edited Loading

DorianMazur commented Sep 23, 2024

haerim95 commented Oct 4, 2024

This comment was marked as off-topic.

DorianMazur commented Oct 10, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

kirasiris commented Nov 3, 2024

jsamr commented Nov 3, 2024

StonedTD commented Nov 6, 2024 • edited Loading

carlos-dubon commented Nov 14, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

nd-gorm commented May 15, 2024 •

edited

Loading

ba361006 commented May 21, 2024 •

edited

Loading

chriszs commented May 28, 2024 •

edited

Loading

bruce-mec commented Sep 4, 2024 •

edited

Loading

DanielKuhn commented Sep 4, 2024 •

edited

Loading

marcpope commented Sep 16, 2024 •

edited

Loading

StonedTD commented Nov 6, 2024 •

edited

Loading