Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't ignore the saved html files and folders #6

Open
xypnox opened this issue Aug 30, 2019 · 3 comments
Open

Doesn't ignore the saved html files and folders #6

xypnox opened this issue Aug 30, 2019 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@xypnox
Copy link
Collaborator

xypnox commented Aug 30, 2019

The timetable page and the folder for the files are currently not ignored in .gitignore.

Add specific rules to ignore these files. Note that the name of the files is different for every student. In my case it was: Welcome Aditya Vikram Singh to ERP, IIT Kharagpur.htm and the folder was named similarly.

@xypnox xypnox added bug Something isn't working good first issue Good for newcomers labels Aug 30, 2019
@Raghwendra-Dey
Copy link
Contributor

Raghwendra-Dey commented Aug 30, 2019

I don't have that much knowledge of html,so pardon for not any mistake,
But i think the file the code is looking for is not the Welcome.....htm one but there is a .html file inside the dir "Welcome ...", that was the main problem which i faced when i tried to use it in my case, then i looked into the code and then searched the file with the req name in the downloaded files then i got the problem...
And btw even if it was the case with the same name i couldn't get the real problem as the code is looking for a file not a dir so it will automatically ignore the folder with the same name...

@xypnox
Copy link
Collaborator Author

xypnox commented Aug 30, 2019 via email

@Raghwendra-Dey
Copy link
Contributor

Raghwendra-Dey commented Sep 1, 2019

Sorry, but i still didn't completely understand....
The problem you are taking about is created due to my patch or it already existed?
And sorry for late reply i was busy due to acads .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants