Need help with error "NameError: method `logger' not defined in Concurrent::MutableStruct::ThreadSafeConfig"

[duknic]

Firstly, need to say that I've only been working with Ruby etc for a couple years, so excuse me 🙏

We have a Padrino app that's undergoing some well needed maintenance to bring it up to a modern Ruby version. Part of that requires moving to a newer padrino version that supports Ruby 3 (0.16.0.pre3). That padrino version depends on rack ~> 3 and so this required us to bump versions of sidekiq and sidekiq-unique-jobs too, we had been on ~> 5 for these.

Since making those changes, the app does not boot and we see the following error. I've reached the extent of my debugging power and need some help from someone who has a deeper understanding of these libraries, please.

Any help or advice or guidance is really appreciated as I'm stuck.

Stack trace

NameError: method `logger' not defined in Concurrent::MutableStruct::ThreadSafeConfig
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb:160:in `remove_method'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb:160:in `block in define_struct_class'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb:159:in `each'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb:159:in `each_with_index'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/abstract_struct.rb:159:in `define_struct_class'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/mutable_struct.rb:223:in `block in define_struct'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `block in synchronize'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `synchronize'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/synchronization/mutex_lockable_object.rb:48:in `synchronize'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/mutable_struct.rb:222:in `define_struct'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/mutable_struct.rb:217:in `new'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/sidekiq-unique-jobs-8.0.10/lib/sidekiq_unique_jobs/config.rb:5:in `<module:SidekiqUniqueJobs>'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/sidekiq-unique-jobs-8.0.10/lib/sidekiq_unique_jobs/config.rb:3:in `<top (required)>'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/sidekiq-unique-jobs-8.0.10/lib/sidekiq_unique_jobs.rb:79:in `<top (required)>'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/sidekiq-unique-jobs-8.0.10/lib/sidekiq-unique-jobs.rb:3:in `<top (required)>'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/usr/local/lib/ruby/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/runtime.rb:60:in `block (2 levels) in require'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/runtime.rb:55:in `each'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/runtime.rb:55:in `block in require'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/runtime.rb:44:in `each'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/runtime.rb:44:in `require'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler.rb:212:in `require'
/home/circleci/project/config/boot.rb:12:in `<top (required)>'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/padrino-core-0.16.0.pre3/lib/padrino-core/cli/rake_tasks.rb:15:in `block in <top (required)>'
/home/circleci/project/vendor/bundle/ruby/3.3.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/cli/exec.rb:58:in `load'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/cli/exec.rb:58:in `kernel_load'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/cli/exec.rb:23:in `run'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/cli.rb:455:in `exec'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/cli.rb:35:in `dispatch'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/cli.rb:29:in `start'
/home/circleci/.rubygems/gems/bundler-2.5.21/exe/bundle:28:in `block in <top (required)>'
/home/circleci/.rubygems/gems/bundler-2.5.21/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/home/circleci/.rubygems/gems/bundler-2.5.21/exe/bundle:20:in `<top (required)>'
/home/circleci/.rubygems/bin/bundle:25:in `load'
/home/circleci/.rubygems/bin/bundle:25:in `<main>'

Gemfile.lock

GEM
  remote: https://rubygems.org/
  specs:
    activemodel (6.1.7.6)
      activesupport (= 6.1.7.6)
    activerecord (6.1.7.6)
      activemodel (= 6.1.7.6)
      activesupport (= 6.1.7.6)
    activesupport (6.1.7.6)
      concurrent-ruby (~> 1.0, >= 1.0.2)
      i18n (>= 1.6, < 2)
      minitest (>= 5.1)
      tzinfo (~> 2.0)
      zeitwerk (~> 2.3)
    addressable (2.8.0)
      public_suffix (>= 2.0.2, < 5.0)
    airbrake (11.0.3)
      airbrake-ruby (~> 5.1)
    airbrake-ruby (5.2.1)
      rbtree3 (~> 0.5)
    ast (2.4.2)
    awesome_print (1.9.2)
    base64 (0.2.0)
    bigdecimal (3.1.8)
    brakeman (6.2.1)
      racc
    bundler-audit (0.9.2)
      bundler (>= 1.2.0, < 3)
      thor (~> 1.0)
    chartkick (4.0.5)
    clockwork (3.0.2)
      activesupport
      tzinfo
    codecov (0.5.2)
      simplecov (>= 0.15, < 0.22)
    coderay (1.1.3)
    concurrent-ruby (1.3.4)
    connection_pool (2.4.1)
    dalli (3.2.7)
      base64
    date (3.3.4)
    diff-lcs (1.5.1)
    distribution (0.8.0)
    docile (1.4.0)
    domain_name (0.5.20190701)
      unf (>= 0.0.5, < 1.0.0)
    dotenv (3.1.4)
    faraday (2.7.10)
      faraday-net_http (>= 2.0, < 3.1)
      ruby2_keywords (>= 0.0.4)
    faraday-net_http (3.0.2)
    foreman (0.87.2)
    forwardable (1.3.3)
    groupdate (6.4.0)
      activesupport (>= 6.1)
    hashie (5.0.0)
    http-cookie (1.0.5)
      domain_name (~> 0.5)
    httpclient (2.8.3)
    i18n (1.14.6)
      concurrent-ruby (~> 1.0)
    json (2.7.2)
    jwt (2.7.1)
    kgio (2.11.4)
    language_server-protocol (3.17.0.3)
    logger (1.6.1)
    mail (2.8.1)
      mini_mime (>= 0.1.1)
      net-imap
      net-pop
      net-smtp
    mechanize (2.8.5)
      addressable (~> 2.8)
      domain_name (~> 0.5, >= 0.5.20190701)
      http-cookie (~> 1.0, >= 1.0.3)
      mime-types (~> 3.0)
      net-http-digest_auth (~> 1.4, >= 1.4.1)
      net-http-persistent (>= 2.5.2, < 5.0.dev)
      nokogiri (~> 1.11, >= 1.11.2)
      rubyntlm (~> 0.6, >= 0.6.3)
      webrick (~> 1.7)
      webrobots (~> 0.1.2)
    method_source (1.0.0)
    mime-types (3.4.1)
      mime-types-data (~> 3.2015)
    mime-types-data (3.2023.0218.1)
    mini_mime (1.1.5)
    mini_portile2 (2.8.7)
    minitest (5.25.1)
    moneta (1.6.0)
    multi_xml (0.7.1)
      bigdecimal (~> 3.1)
    mustermann (3.0.3)
      ruby2_keywords (~> 0.0.1)
    net-http-digest_auth (1.4.1)
    net-http-persistent (4.0.1)
      connection_pool (~> 2.2)
    net-imap (0.4.17)
      date
      net-protocol
    net-pop (0.1.2)
      net-protocol
    net-protocol (0.2.2)
      timeout
    net-smtp (0.5.0)
      net-protocol
    newrelic_rpm (9.14.0)
    nokogiri (1.16.7)
      mini_portile2 (~> 2.8.2)
      racc (~> 1.4)
    oauth2 (2.0.9)
      faraday (>= 0.17.3, < 3.0)
      jwt (>= 1.0, < 3.0)
      multi_xml (~> 0.5)
      rack (>= 1.2, < 4)
      snaky_hash (~> 2.0)
      version_gem (~> 1.1)
    omniauth (2.1.2)
      hashie (>= 3.4.6)
      rack (>= 2.2.3)
      rack-protection
    omniauth-google-oauth2 (1.1.1)
      jwt (>= 2.0)
      oauth2 (~> 2.0.6)
      omniauth (~> 2.0)
      omniauth-oauth2 (~> 1.8.0)
    omniauth-oauth2 (1.8.0)
      oauth2 (>= 1.4, < 3)
      omniauth (~> 2.0)
    padrino (0.16.0.pre3)
      padrino-admin (= 0.16.0.pre3)
      padrino-cache (= 0.16.0.pre3)
      padrino-core (= 0.16.0.pre3)
      padrino-gen (= 0.16.0.pre3)
      padrino-helpers (= 0.16.0.pre3)
      padrino-mailer (= 0.16.0.pre3)
      padrino-support (= 0.16.0.pre3)
    padrino-admin (0.16.0.pre3)
      padrino-core (= 0.16.0.pre3)
      padrino-helpers (= 0.16.0.pre3)
    padrino-cache (0.16.0.pre3)
      moneta (~> 1.6)
      padrino-core (= 0.16.0.pre3)
      padrino-helpers (= 0.16.0.pre3)
    padrino-core (0.16.0.pre3)
      padrino-support (= 0.16.0.pre3)
      rackup (~> 2.1)
      sinatra (~> 4)
      thor (~> 1.0)
    padrino-gen (0.16.0.pre3)
      bundler (>= 1.0, < 3)
      padrino-core (= 0.16.0.pre3)
    padrino-helpers (0.16.0.pre3)
      i18n (>= 0.6.7, < 2)
      padrino-support (= 0.16.0.pre3)
      tilt (>= 1.4.1, < 3)
    padrino-mailer (0.16.0.pre3)
      mail (~> 2.5)
      mime-types (< 4)
      padrino-core (= 0.16.0.pre3)
    padrino-support (0.16.0.pre3)
    parallel (1.26.3)
    parser (3.3.5.0)
      ast (~> 2.4.1)
      racc
    pg (1.4.6)
    prime (0.1.2)
      forwardable
      singleton
    pry (0.14.1)
      coderay (~> 1.1)
      method_source (~> 1.0)
    public_suffix (4.0.7)
    racc (1.8.1)
    rack (3.1.8)
    rack-protection (4.0.0)
      base64 (>= 0.1.0)
      rack (>= 3.0.0, < 4)
    rack-session (2.0.0)
      rack (>= 3.0.0)
    rack-ssl-enforcer (0.2.9)
    rackup (2.1.0)
      rack (>= 3)
      webrick (~> 1.8)
    rainbow (3.1.1)
    raindrops (0.20.1)
    rake (13.0.6)
    rbtree3 (0.7.1)
    redis (4.5.1)
    redis-client (0.22.2)
      connection_pool
    regexp_parser (2.9.2)
    rspec (3.13.0)
      rspec-core (~> 3.13.0)
      rspec-expectations (~> 3.13.0)
      rspec-mocks (~> 3.13.0)
    rspec-core (3.13.1)
      rspec-support (~> 3.13.0)
    rspec-expectations (3.13.3)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.13.0)
    rspec-mocks (3.13.2)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.13.0)
    rspec-support (3.13.1)
    rspec_junit_formatter (0.4.1)
      rspec-core (>= 2, < 4, != 2.12.0)
    rubocop (1.66.1)
      json (~> 2.3)
      language_server-protocol (>= 3.17.0)
      parallel (~> 1.10)
      parser (>= 3.3.0.2)
      rainbow (>= 2.2.2, < 4.0)
      regexp_parser (>= 2.4, < 3.0)
      rubocop-ast (>= 1.32.2, < 2.0)
      ruby-progressbar (~> 1.7)
      unicode-display_width (>= 2.4.0, < 3.0)
    rubocop-ast (1.32.3)
      parser (>= 3.3.1.0)
    rubocop-performance (1.22.1)
      rubocop (>= 1.48.1, < 2.0)
      rubocop-ast (>= 1.31.1, < 2.0)
    rubocop-rspec (3.1.0)
      rubocop (~> 1.61)
    ruby-progressbar (1.13.0)
    ruby2_keywords (0.0.5)
    ruby_http_client (3.5.2)
    rubyntlm (0.6.3)
    sendgrid-ruby (6.4.0)
      ruby_http_client (~> 3.4)
    sentry-ruby (5.20.1)
      bigdecimal
      concurrent-ruby (~> 1.0, >= 1.0.2)
    sentry-sidekiq (5.20.1)
      sentry-ruby (~> 5.20.1)
      sidekiq (>= 3.0)
    sidekiq (7.3.2)
      concurrent-ruby (< 2)
      connection_pool (>= 2.3.0)
      logger
      rack (>= 2.2.4)
      redis-client (>= 0.22.2)
    sidekiq-unique-jobs (8.0.10)
      concurrent-ruby (~> 1.0, >= 1.0.5)
      sidekiq (>= 7.0.0, < 8.0.0)
      thor (>= 1.0, < 3.0)
    simplecov (0.21.2)
      docile (~> 1.1)
      simplecov-html (~> 0.11)
      simplecov_json_formatter (~> 0.1)
    simplecov-html (0.12.3)
    simplecov_json_formatter (0.1.3)
    sinatra (4.0.0)
      mustermann (~> 3.0)
      rack (>= 3.0.0, < 4)
      rack-protection (= 4.0.0)
      rack-session (>= 2.0.0, < 3)
      tilt (~> 2.0)
    singleton (0.2.0)
    snaky_hash (2.0.1)
      hashie
      version_gem (~> 1.1, >= 1.1.1)
    thor (1.3.2)
    tilt (2.4.0)
    timeout (0.4.1)
    tzinfo (2.0.6)
      concurrent-ruby (~> 1.0)
    unf (0.1.4)
      unf_ext
    unf_ext (0.0.8.2)
    unicode-display_width (2.6.0)
    unicorn (6.1.0)
      kgio (~> 2.6)
      raindrops (~> 0.7)
    version_gem (1.1.4)
    webrick (1.8.2)
    webrobots (0.1.2)
    will_paginate (4.0.1)
    zeitwerk (2.6.18)
    zipruby (0.3.6)

[francesmcmullin]

Hi @duknic 👋🏻

We both work on a project affected by this issue, for detailed discussion of the error I'd recommend this comment on that private repo.

In summary - Padrino monkey patches Kernel with a logger method, while concurrent ruby strips methods from Object (which inherits from Kernel) - the error occurs when attempting to do Object.send :remove_method, :logger because the method is defined on the parent (Kernel), not on Object.

In terms of a fix, I believe the logical candidates are either concurrent ruby (use undef_method instead of remove_method) or Padrino (stop monkey patching Kernel), not sidekiq-unique-jobs, which seems to be using concurrent ruby in a perfectly reasonable way.

[Sidenote - while it's definitely preferrable to upgrade Padrino, Sidekiq and Sidekiq Unique Jobs, we can still get at least as far as Ruby 3.1.4 without those upgrades]

[duknic]

@francesmcmullin, thanks for finding this post so fast and sharing your insight.
Fwiw, I've changed roles and so no longer have access to that private repo you linked but your summary is good 👍

You have a better grasp of the issue than me, could you share this with the concurrent-ruby/padrino authors and see if they could advise? Or better still, if you thought it was suitable, just PR the change to the concurrent-ruby/padrino project directly. Both projects seem relatively active so feeling good about a fix 🤞

I understand that Ruby 3.1 will EOL early next year so aiming to move closer to the edge than that with the project I'm working on.

Thanks again for your help

[francesmcmullin]

Ah, sorry for assuming! I know the last time I looked at this I wasn't very optimistic about merging a fix (certainly, Padrino is not that active any more), the other option is to fork either project.

For Speakout (the private repo linked above), we've basically accepted the older versions of Sidekiq and Sidekiq Unique Jobs (while we miss out on a lot of the newer web UI features, we also avoid the related security issues).

I've opened an issue in concurrent ruby here, I'm more optimistic that they might make the fix and publish a new release, I'll leave it to you to see if you can speed that up.

[duknic]

@francesmcmullin Great work on the PR, this is touching realms of Ruby I have no idea about so I'm very grateful for your help.