Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: DotNetCoreCLI@2 Task should pass MSBuild logger to all MSBuild based tatsks #18990

Open
afscrome opened this issue Sep 19, 2023 · 1 comment

Comments

@afscrome
Copy link

Task name

DotNetCoreCLI@2

Describe your feature request here

The DotNetCoreCLI task has a custom MSBuild logger to easily show errors & warnings in the Azure Devops UI, which is great. However this logger is currently only passed in to the build command, so doesn't clearly highlight restore, test or publish failures.

if (this.isBuildCommand()) {
var loggerAssembly = path.join(__dirname, 'dotnet-build-helpers/Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll');
dotnet.arg(`-dl:CentralLogger,\"${loggerAssembly}\"*ForwardingLogger,\"${loggerAssembly}\"`);
}

This logger should be passed in to dotnet commands that use msbuild under the hood. I the commands this should be done for are :

  • build
  • format
  • msbuild
  • pack
  • publish
  • restore
  • run
  • test
@KirillOsenkov
Copy link
Member

This seems the same as #16366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants