Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism to disable motion on a per motion component instance #33090

Closed
pixel-perfectionist opened this issue Oct 21, 2024 · 3 comments · May be fixed by #33091
Closed

Mechanism to disable motion on a per motion component instance #33090

pixel-perfectionist opened this issue Oct 21, 2024 · 3 comments · May be fixed by #33091
Assignees

Comments

@pixel-perfectionist
Copy link
Member

In order to adequately react to instance level changes we need a mechanism to disable motion per instance, in addition to the global setting provided by Teams, browser, or OS.

@layershifter
Copy link
Member

Let's avoid adding new mechanisms. There is already MotionBehaviorProvider & null can be passed to motion slots.

@ling1726
Copy link
Member

@akatrukhin can you please add more details to your PoC PR to show how components would be affected by this change?

@robertpenner
Copy link
Collaborator

Discussed this with @akatrukhin, taking into account the feedback from Shift and Ling. We agreed:

  • This isn't necessary for beta.
  • The solution for resolving the conflict between 2 levels of MotionBehaviourContext in Teams is different than this feature, and seems to be best handled with a simple boolean expression in Teams code.
  • There may use cases for this feature in the future, but it's not a priority, and as @layershifter said, we want to keep the mechanisms simple at this stage.
    Thus, we are closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants