Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MessageBarGroup] Migrate to Fade motion component #33429

Closed
robertpenner opened this issue Dec 9, 2024 · 2 comments
Closed

[MessageBarGroup] Migrate to Fade motion component #33429

robertpenner opened this issue Dec 9, 2024 · 2 comments
Assignees

Comments

@robertpenner
Copy link
Collaborator

robertpenner commented Dec 9, 2024

MessageBarGroup uses Griffel animationName for opacity transitions:

// useMessageBarGroupStyles.styles.ts
enter: {
  animationName: {
    from: {
      opacity: 0,
      transform: 'translateY(-100%)',
    },
    to: {
      opacity: 1,
      transform: 'translateY(0)',
    },
  },
},

exit: {
  animationName: {
    from: {
      opacity: 1,
    },
    to: {
      opacity: 0,
    },
  },
},

Replace the opacity CSS keyframes with a Fade motion component.

@robertpenner robertpenner self-assigned this Dec 9, 2024
@robertpenner
Copy link
Collaborator Author

Pausing to investigate migration of fade + slide together.

@layershifter
Copy link
Member

Closing as a dupe as there is #33470.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants