Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different handling environment (missing dotenv.load_dotenv() in sample 08) #542

Closed
bmerkle opened this issue Jul 29, 2024 · 2 comments
Closed
Assignees

Comments

@bmerkle
Copy link
Contributor

bmerkle commented Jul 29, 2024

Describe the bug
most python samples use

# import dotenv
dotenv.load_dotenv()

However in sample08 the environment variables are only used, (so .env files are ignored)
e.g. transcript_enrich_summaries.py

# no usage of dotenv
API_KEY = os.environ["AZURE_OPENAI_API_KEY"]

I could contribute a patch/merge request for this.

To Reproduce
all python programs transcript*.py in C:\work\microsoft\generative-ai-for-beginners\08-building-search-applications\scripts
are missing dotenv and are using the environment variables only.

Expected behavior
dotenv should be used in all examples

Copy link

👋 Thanks for contributing @bmerkle! We will review the issue and get back to you soon.

@bmerkle
Copy link
Contributor Author

bmerkle commented Sep 9, 2024

is fixed via #577

@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants