Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chapter21: improvements for notebook #609

Closed
bmerkle opened this issue Oct 5, 2024 · 3 comments
Closed

chapter21: improvements for notebook #609

bmerkle opened this issue Oct 5, 2024 · 3 comments
Assignees
@koreyspace
Labels
needs-review no-issue-activity

Comments

@bmerkle
Copy link
Contributor

bmerkle commented Oct 5, 2024

Describe the bug

  • enumeration of the lama model variants in README and notebook should have line breaks
  • notebook should install the necessary pip packages.

both issues are fixed with PRs

#607
#608
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

👋 Thanks for contributing @bmerkle! We will review the issue and get back to you soon.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

This issue has not seen any action for a while! Closing for now, but it can be reopened at a later date.

@bmerkle
Copy link
Contributor Author

bmerkle commented Dec 9, 2024

both issues are fixed with PRs

#607
#608

@bmerkle bmerkle closed this as completed Dec 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@koreyspace koreyspace

Labels
needs-review no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmerkle @koreyspace