Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: LLamaSharp Connector #3235

Closed
KSemenenko opened this issue Oct 18, 2023 · 4 comments
Closed

.Net: LLamaSharp Connector #3235

KSemenenko opened this issue Oct 18, 2023 · 4 comments
Labels
ai connector Anything related to AI connectors .NET Issue or Pull requests regarding .NET code

Comments

@KSemenenko
Copy link

I think it would be a good idea to add a C# connector for LLamaSharp

https://github.com/SciSharp/LLamaSharp
I think it might be a good idea

@shawncal shawncal added .NET Issue or Pull requests regarding .NET code triage labels Oct 18, 2023
@github-actions github-actions bot changed the title LLamaSharp Connector .Net: LLamaSharp Connector Oct 18, 2023
@KSemenenko
Copy link
Author

related #1215

@dmytrostruk
Copy link
Member

@KSemenenko Thanks for creating this issue!
It's definitely a good idea to add LLamaSharp Connector, which would be compatible with Semantic Kernel. At the moment, we are trying to find mechanism how to add new Connectors and Plugins to SK ecosystem in a scalable way.

As the amount of possible extensions for SK grows really fast, we encourage Connector and Plugin authors to add new implementations in their own repositories and share it with us. It will allow us to keep this repository for SK Core functionality only, while authors can manage and structure their code for SK extensions in a best possible way.

Please let us know if this makes sense. We would be happy to see new SK Connector! :)

@stephentoub
Copy link
Member

We would be happy to see new SK Connector! :)

The cited repo already provides one:
https://github.com/SciSharp/LLamaSharp/tree/master/LLama.SemanticKernel
https://www.nuget.org/packages/LLamaSharp.semantic-kernel

It'd be good, though, if SK folks could review it to ensure it's following desired conventions, implementing functionality in the desired way, etc.

@evchaki evchaki added the ai connector Anything related to AI connectors label Oct 19, 2023
@matthewbolanos
Copy link
Member

Going to close this as a duplicate of #1215. We'll be working with the LlamaSharp contributors to make sure their connector works as expected with Semantic kernel.

@matthewbolanos matthewbolanos closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai connector Anything related to AI connectors .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

No branches or pull requests

6 participants