Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Azure function calling missing 'enum' support for parameters #3292

Closed
lavinir opened this issue Oct 25, 2023 · 1 comment · Fixed by #3532
Closed

.Net: Azure function calling missing 'enum' support for parameters #3292

lavinir opened this issue Oct 25, 2023 · 1 comment · Fixed by #3532
Assignees
Labels
.NET Issue or Pull requests regarding .NET code

Comments

@lavinir
Copy link

lavinir commented Oct 25, 2023

Current implementation does not have support for indicating a closed list of 'enum' values used in the FunctionDefinition. As per the supported Function Calling Schema in Azure OpenAI. See examples here

Expected behavior
Add support for defining enum values for a function parameter.

Platform

  • Language: [C#]
  • Source: [latest nuget preview, main branch of repository]

Additional context
Add any other context about the problem here.

@shawncal shawncal added .NET Issue or Pull requests regarding .NET code triage labels Oct 25, 2023
@github-actions github-actions bot changed the title Azure function calling missing 'enum' support for parameters .Net: Azure function calling missing 'enum' support for parameters Oct 25, 2023
@matthewbolanos
Copy link
Member

Today we don't currently support the enum type for SKFunctions. Before we get enum support for Azure OpenAI function calling, we need to get arbitrary object types for SKFunctions (both input and outputs). We've started to look into this.

@matthewbolanos matthewbolanos assigned alliscode and unassigned gitri-ms Oct 25, 2023
@markwallace-microsoft markwallace-microsoft moved this to Sprint: Planned in Semantic Kernel Nov 6, 2023
@markwallace-microsoft markwallace-microsoft moved this from Sprint: Planned to Sprint: In Progress in Semantic Kernel Nov 13, 2023
@markwallace-microsoft markwallace-microsoft moved this from Sprint: In Progress to Sprint: Planned in Semantic Kernel Nov 14, 2023
@markwallace-microsoft markwallace-microsoft moved this from Sprint: Planned to Sprint: In Progress in Semantic Kernel Nov 16, 2023
@markwallace-microsoft markwallace-microsoft moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernel Nov 16, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
…ing (#3532)

### Motivation and Context

Resolves #3292

### Description

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@github-project-automation github-project-automation bot moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
Archived in project
6 participants