-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Bug: retry_machanism is not used #9015
Comments
@TaoChenOSU could you have a look at this, please? |
Is there anything I can clarify or adjust to support you better here? |
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> In Python, we have the `retry_mechanism` property in the kernel but it's never used. Address: #9015 ### Description 1. Deprecate the retry_mechanism field. 2. Add a sample showing how to perform retries with the kernel using filter. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Hi @CBumann, the The recommended way to perform retry on a kernel function is now through Please let us know if using a filter is enough for your scenario and what additional features you'd like to see in SK! |
Describe the bug
The Kernel class has a property retry_mechnism.
This is intended to be set to a Implementation of RetryMechanismBase from the semantic_kernel.reliability extension to handle the retry logic.
However this property seems to never be used, leaving us unable to handle retries in the intended way.
This was tested both with the kernel.invoke functions as well as with get_chat_message_content.
To Reproduce
Code Sample to reproduce:
The test above fails, because FailingRetryMechanism is never used.
Expected behavior
The provided retry mechanism should be used..
Platform
The text was updated successfully, but these errors were encountered: