From 5bdb5d15d05f737de36356e3a96fe69eaf57a6a3 Mon Sep 17 00:00:00 2001 From: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Date: Fri, 13 Dec 2024 10:28:30 -0500 Subject: [PATCH 1/4] Removed System.Memory.Data dependency --- dotnet/Directory.Packages.props | 1 - .../src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj | 1 - 2 files changed, 2 deletions(-) diff --git a/dotnet/Directory.Packages.props b/dotnet/Directory.Packages.props index a032edea6116..29919cf2e270 100644 --- a/dotnet/Directory.Packages.props +++ b/dotnet/Directory.Packages.props @@ -52,7 +52,6 @@ - diff --git a/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj b/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj index 1e95741e153e..e3452f799be6 100644 --- a/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj +++ b/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj @@ -25,7 +25,6 @@ - From a752132c51f28abbc47a0572ff2f63891aaf543b Mon Sep 17 00:00:00 2001 From: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Date: Fri, 13 Dec 2024 11:08:46 -0500 Subject: [PATCH 2/4] Revert "Removed System.Memory.Data dependency" This reverts commit 5bdb5d15d05f737de36356e3a96fe69eaf57a6a3. --- dotnet/Directory.Packages.props | 1 + .../src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj | 1 + 2 files changed, 2 insertions(+) diff --git a/dotnet/Directory.Packages.props b/dotnet/Directory.Packages.props index 29919cf2e270..a032edea6116 100644 --- a/dotnet/Directory.Packages.props +++ b/dotnet/Directory.Packages.props @@ -52,6 +52,7 @@ + diff --git a/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj b/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj index e3452f799be6..1e95741e153e 100644 --- a/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj +++ b/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj @@ -25,6 +25,7 @@ + From bf14a046a7698060177737a998f8b61602f772ae Mon Sep 17 00:00:00 2001 From: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Date: Fri, 13 Dec 2024 11:26:04 -0500 Subject: [PATCH 3/4] Reapply "Removed System.Memory.Data dependency" This reverts commit a752132c51f28abbc47a0572ff2f63891aaf543b. --- dotnet/Directory.Packages.props | 1 - .../src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj | 1 - 2 files changed, 2 deletions(-) diff --git a/dotnet/Directory.Packages.props b/dotnet/Directory.Packages.props index a032edea6116..29919cf2e270 100644 --- a/dotnet/Directory.Packages.props +++ b/dotnet/Directory.Packages.props @@ -52,7 +52,6 @@ - diff --git a/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj b/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj index 1e95741e153e..e3452f799be6 100644 --- a/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj +++ b/dotnet/src/SemanticKernel.UnitTests/SemanticKernel.UnitTests.csproj @@ -25,7 +25,6 @@ - From 4c1ba7c1a28f5f887252f6e89f3ecb29efb68bc9 Mon Sep 17 00:00:00 2001 From: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com> Date: Fri, 13 Dec 2024 11:36:31 -0500 Subject: [PATCH 4/4] Small fix --- .../Extensions/ClientResultExceptionExtensionsTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dotnet/src/SemanticKernel.UnitTests/Extensions/ClientResultExceptionExtensionsTests.cs b/dotnet/src/SemanticKernel.UnitTests/Extensions/ClientResultExceptionExtensionsTests.cs index f7a4e947ec38..c9c348d1ac44 100644 --- a/dotnet/src/SemanticKernel.UnitTests/Extensions/ClientResultExceptionExtensionsTests.cs +++ b/dotnet/src/SemanticKernel.UnitTests/Extensions/ClientResultExceptionExtensionsTests.cs @@ -64,7 +64,7 @@ public void ItProvideStatusForResponsesWithoutContent() // Assert Assert.NotNull(httpOperationException); Assert.NotNull(httpOperationException.StatusCode); - Assert.Empty(httpOperationException.ResponseContent!); + Assert.Null(httpOperationException.ResponseContent); Assert.Equal(exception, httpOperationException.InnerException); Assert.Equal(exception.Message, httpOperationException.Message); Assert.Equal(pipelineResponse.Status, (int)httpOperationException.StatusCode!);