Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] mgt-chat some chat messages are not formatted properly #3000

Closed
plasne opened this issue Jan 30, 2024 · 3 comments
Closed

[BUG] mgt-chat some chat messages are not formatted properly #3000

plasne opened this issue Jan 30, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@plasne
Copy link

plasne commented Jan 30, 2024

@musale
After commit 511f6ea, related to "full screen error messages"...

Given a message with multiple HTML tags:

Thanks for using the Teams App Studio! I'm here to let you know if there's something that needs your attention in the app or if there's anything new and interesting to check out. I can help you search for documentation with my search command or you can find most of what you need here. Otherwise, use the Manifest and Card editors to start building your app. Have fun!

image

Here is what it looked like before the commit:

image

This appears to be because "display: inline-flex" is being passed down.

image
@plasne plasne added bug Something isn't working Needs: Triage 🔍 labels Jan 30, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Graph Toolkit Jan 30, 2024
@gavinbarron gavinbarron moved this from Needs Triage 🔍 to Todo 📃 in Graph Toolkit Jan 30, 2024
@gavinbarron gavinbarron changed the title [BUG] After full-screen-error-messages commit, some messages are not formatted properly [BUG] mgt-chat some chat messages are not formatted properly Jan 30, 2024
@sebastienlevert sebastienlevert added this to the Chat - GA milestone Jan 31, 2024
@musale
Copy link
Contributor

musale commented Feb 1, 2024

Hm... let me get a dig at this @plasne. Thank you for bringing this up.

@musale musale self-assigned this Feb 1, 2024
@musale musale moved this from Todo 📃 to In Progress 🚧 in Graph Toolkit Feb 1, 2024
@musale
Copy link
Contributor

musale commented Feb 1, 2024

@plasne I'm unable to reproduce this with the current next/mgt-chat release. I have tried your text, as well as this text:

Check this out fix and also this Issue #3000 and let me know

image

but I can't see the error. I'm I missing something?

@plasne
Copy link
Author

plasne commented Feb 1, 2024

At the time I created this we were up-to-date with all commits from next/mgt-chat. It was not working (hence the screenshots). However, there has been 1 or 2 commits since then that we have merged and now it is working properly. So, feel free to close this.

@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Graph Toolkit Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants