Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request for nn_transformer_encoder, nn_transformer_encoder_layer, nn_transformer_decoder, and nn_transformer_decoder_layer #1209

Open
MaximilianPi opened this issue Nov 6, 2024 · 1 comment
Open

Feature request for nn_transformer_encoder, nn_transformer_encoder_layer, nn_transformer_decoder, and nn_transformer_decoder_layer #1209

MaximilianPi opened this issue Nov 6, 2024 · 1 comment

Comments

@MaximilianPi
Copy link
Contributor

It would be nice to have the transformer objects in Torch.

Actually, I have already implemented most of them (by translating the pytorch code https://github.com/pytorch/pytorch/blob/main/torch/nn/modules/transformer.py ), so I could do a PR if you want.
@cregouby
Copy link
Collaborator

cregouby commented Nov 9, 2024 •
edited
Loading

Hello @MaximilianPi
Please do !

@rplain1 rplain1 mentioned this issue Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cregouby @MaximilianPi